Skip to content

Better Null format for tcp handler.#7606

Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
amosbird:nullformat
Nov 4, 2019
Merged

Better Null format for tcp handler.#7606
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
amosbird:nullformat

Conversation

@amosbird
Copy link
Collaborator

@amosbird amosbird commented Nov 4, 2019

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

For changelog. Remove if this is non-significant change.

Category (leave one):

  • Improvement

Short description (up to few sentences):

so that we can use select ignore(<expression>) from table format Null for perf measure via clickhouse-client

@amosbird amosbird changed the title Better null format for tcp handler. Better Null format for tcp handler. Nov 4, 2019
Copy link
Member

@alexey-milovidov alexey-milovidov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.

@alexey-milovidov
Copy link
Member

I always kept this in mind but refused to implement because of limited benefits and compromised simplicity of code. But it's still nice to have.

@alexey-milovidov alexey-milovidov merged commit 782e2f6 into ClickHouse:master Nov 4, 2019
@alexey-milovidov
Copy link
Member

alexey-milovidov commented Nov 4, 2019

I also used Null format to test network throughput:

clickhouse-client --progress --host remote-server --query 'SELECT rand64() FROM system.numbers FORMAT Null'

Now this use case will fail :(

@alexey-milovidov
Copy link
Member

Probably your use case outweight my use case :)

@amosbird
Copy link
Collaborator Author

amosbird commented Nov 4, 2019

I also used Null format to test network throughput:

clickhouse-client --host remote-server --query 'SELECT rand64() FROM system.numbers FORMAT Null'

Now this use case will fail :(

Interesting use case. Perhaps we can revert this and implement alternative. I also tried extending the SELECT INTO OUTFILE grammar as SELECT INTO NULL.

@CurtizJ CurtizJ added the pr-improvement Pull request with some product improvements label Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-improvement Pull request with some product improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants