Fix: constant ALIAS with parallel replicas#77210
Open
yakov-olkhovskiy wants to merge 1 commit intomasterfrom
Open
Fix: constant ALIAS with parallel replicas#77210yakov-olkhovskiy wants to merge 1 commit intomasterfrom
yakov-olkhovskiy wants to merge 1 commit intomasterfrom
Conversation
Contributor
clickhouse-gh
bot
added
the
pr-bugfix
novikd
reviewed
Mar 6, 2025
| roots.push_back(&node); | ||
|
|
||
| /// Preserve constants | ||
| if (node.type == ActionType::COLUMN && isColumnConst(*node.column)) |
Member
There was a problem hiding this comment.
Is it about a constant that appeared in this ActionDAG and supposed to be a part of outputs?
Member
Author
There was a problem hiding this comment.
yes, it's all result of ActionsChain generation where const column would not propagate from projection to previous step because it's const - i.e. doesn't depend on any input... it's all complicated and hacky and apparently doesn't work properly - many tests are failing
Member
Author
There was a problem hiding this comment.
PS see buildExpressionAnalysisResult - building of ActionsChain actions_chain
Contributor
|
Dear @novikd, this PR hasn't been updated for a while. You will be unassigned. Will you continue working on it? If so, please feel free to reassign yourself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix: constant ALIAS selected with parallel replicas resulting THERE_IS_NO_COLUMN exception.
closes #76925