Skip to content

Allow to specify metadata file for Iceberg#77318

Merged
alesapin merged 4 commits intomasterfrom
add_iceberg_setting_for_metadata
Mar 10, 2025
Merged

Allow to specify metadata file for Iceberg#77318
alesapin merged 4 commits intomasterfrom
add_iceberg_setting_for_metadata

Conversation

@alesapin
Copy link
Member

@alesapin alesapin commented Mar 7, 2025

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Allow to explicitly specify metadata file to read for Iceberg with storage/table function setting iceberg_metadata_file_path . Fixes #47412.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link
Contributor

clickhouse-gh bot commented Mar 7, 2025

Workflow [PR], commit [51da31b]

@clickhouse-gh clickhouse-gh bot added the pr-improvement Pull request with some product improvements label Mar 7, 2025
@alesapin alesapin requested review from divanik and kssenii March 9, 2025 12:26
@hanfei1991 hanfei1991 self-assigned this Mar 10, 2025
@alesapin alesapin added this pull request to the merge queue Mar 10, 2025
Merged via the queue into master with commit cb7f3b0 Mar 10, 2025
125 checks passed
@alesapin alesapin deleted the add_iceberg_setting_for_metadata branch March 10, 2025 13:30
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Mar 10, 2025
@kssenii kssenii added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Mar 18, 2025
@alexey-milovidov
Copy link
Member

alexey-milovidov commented Mar 18, 2025

Why backporting?

@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Mar 19, 2025
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-backports-created-cloud deprecated label, NOOP label Mar 19, 2025
@kssenii
Copy link
Member

kssenii commented Mar 19, 2025

Why backporting?

Because this bug fix #77486, which I want to backport, depends on this change


bool allow_dynamic_metadata_for_data_lakes = false;
bool allow_experimental_delta_kernel_rs = false;
StorageObjectStorageSettingsPtr storage_settings;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose this should be added to

StorageObjectStorage::Configuration::Configuration(const Configuration & other)

@robot-clickhouse robot-clickhouse added the pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR label Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-improvement Pull request with some product improvements pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow Iceberg table engine to point to a specific metadata file

9 participants