Add icebergTruncate function and support it in partition pruning for Iceberg#77403
Merged
Add icebergTruncate function and support it in partition pruning for Iceberg#77403
icebergTruncate function and support it in partition pruning for Iceberg#77403Conversation
Contributor
clickhouse-gh
bot
added
the
pr-not-for-changelog
bharatnc
reviewed
Mar 11, 2025
src/Functions/icebergTruncate.cpp
Outdated
|
|
||
| REGISTER_FUNCTION(icebergTruncate) | ||
| { | ||
| factory.registerFunction<FunctionIcebergTruncate>(); |
Contributor
There was a problem hiding this comment.
We would need to register new functions with documentation - related CI failures.
Contributor
|
Wondering if this PR should be a feature category with a changelog? |
divanik
reviewed
Mar 11, 2025
alesapin
changed the title
icebergTruncate functionicebergTruncate function and support partition pruning for Iceberg
alesapin
changed the title
icebergTruncate function and support partition pruning for IcebergicebergTruncate function and support it in partition pruning for Iceberg
clickhouse-gh
bot
added
pr-feature
bharatnc
reviewed
Mar 14, 2025
bharatnc
reviewed
Mar 14, 2025
bharatnc
reviewed
Mar 14, 2025
bharatnc
reviewed
Mar 14, 2025
bharatnc
reviewed
Mar 14, 2025
src/Storages/ObjectStorage/DataLakes/Iceberg/PartitionPruning.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Bharat Nallan <[email protected]>
Co-authored-by: Bharat Nallan <[email protected]>
Co-authored-by: Bharat Nallan <[email protected]>
…se into add_iceberg_truncate
bharatnc
approved these changes
Mar 14, 2025
divanik
reviewed
Mar 17, 2025
divanik
reviewed
Mar 17, 2025
divanik
reviewed
Mar 17, 2025
src/Storages/ObjectStorage/DataLakes/Iceberg/PartitionPruning.h
Outdated
Show resolved
Hide resolved
divanik
reviewed
Mar 17, 2025
Member
divanik
left a comment
divanik
left a comment
There was a problem hiding this comment.
Minor changes, generally LGTM
Member
Author
|
It's weird that docs check failed with "no documentation added for new feature". I've added docs in code for all three new functions. |
robot-clickhouse-ci-1
added
the
pr-synced-to-cloud
Contributor
I think it expects markdown documentation. |
ianton-ru
pushed a commit
to Altinity/ClickHouse
that referenced
this pull request
Apr 11, 2025
Add `icebergTruncate` function and support it in partition pruning for Iceberg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add 3 new functions.
icebergTruncateaccording to specification. https://iceberg.apache.org/spec/#truncate-transform-details,toYearNumSinceEpochandtoMonthNumSinceEpoch. Supporttruncatetransform in partition pruning forIcebergengine.Documentation entry for user-facing changes