Merged
Conversation
…pshot when comparing IcebergMetadata equality
…oerner/iceberg-query-timestamp
…oerner/iceberg-query-timestamp
…oerner/iceberg-query-timestamp
Contributor
…k/iceberg_time_travel_by_snapshots
hanfei1991
reviewed
Mar 14, 2025
Member
hanfei1991
left a comment
There was a problem hiding this comment.
didn't finish the review. but let's address these comments
src/Storages/ObjectStorage/DataLakes/Iceberg/IcebergMetadata.cpp
Outdated
Show resolved
Hide resolved
src/Storages/ObjectStorage/DataLakes/Iceberg/IcebergMetadata.cpp
Outdated
Show resolved
Hide resolved
src/Storages/ObjectStorage/DataLakes/Iceberg/IcebergMetadata.cpp
Outdated
Show resolved
Hide resolved
src/Storages/ObjectStorage/DataLakes/Iceberg/IcebergMetadata.cpp
Outdated
Show resolved
Hide resolved
src/Storages/ObjectStorage/DataLakes/Iceberg/IcebergMetadata.cpp
Outdated
Show resolved
Hide resolved
src/Storages/ObjectStorage/DataLakes/Iceberg/IcebergMetadata.cpp
Outdated
Show resolved
Hide resolved
hanfei1991
reviewed
Mar 17, 2025
hanfei1991
approved these changes
Mar 18, 2025
…:ClickHouse/ClickHouse into divanik/iceberg_time_travel_by_snapshots
ianton-ru
pushed a commit
to Altinity/ClickHouse
that referenced
this pull request
Apr 11, 2025
…ime_travel_by_snapshots Iceberg time travel by snapshots
ianton-ru
pushed a commit
to Altinity/ClickHouse
that referenced
this pull request
May 23, 2025
…ime_travel_by_snapshots Iceberg time travel by snapshots
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category:
Changelog entry:
Allows a user to query the state of an Iceberg table as it existed at a previous point in time.
Documentation entry for user-facing changes