Refactor some code in Iceberg Storage#78021
Merged
hanfei1991 merged 6 commits intoClickHouse:masterfrom Mar 21, 2025
Merged
Conversation
Contributor
clickhouse-gh
bot
added
the
pr-not-for-changelog
divanik
reviewed
Mar 20, 2025
divanik
approved these changes
Mar 21, 2025
Merged
via the queue into
ClickHouse:master
with commit Mar 21, 2025
60f0ca1
115 of 128 checks passed
robot-ch-test-poll3
added
the
pr-synced-to-cloud
ianton-ru
pushed a commit
to Altinity/ClickHouse
that referenced
this pull request
Apr 11, 2025
…ceberg Refactor some code in Iceberg Storage
ianton-ru
pushed a commit
to Altinity/ClickHouse
that referenced
this pull request
May 23, 2025
…ceberg Refactor some code in Iceberg Storage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use shared_ptr instead of
IteratorWrapper, which makes code simpler.Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
...
Documentation entry for user-facing changes