Trivial count optimization for iceberg#78090
Merged
Conversation
Member
Author
|
Example with my debug build in eu while Iceberg table is stored in us-west-2: Still I think something is not right and it should be faster, but it's not because of trivial count optimization. |
Contributor
nikitamikhaylov
approved these changes
Mar 23, 2025
ianton-ru
pushed a commit
to Altinity/ClickHouse
that referenced
this pull request
Apr 11, 2025
…_iceberg Trivial count optimization for iceberg
ianton-ru
pushed a commit
to Altinity/ClickHouse
that referenced
this pull request
May 23, 2025
…_iceberg Trivial count optimization for iceberg
azat
reviewed
May 31, 2025
| { | ||
| result += *column_info.bytes_size; | ||
| found = true; | ||
| break; |
Member
There was a problem hiding this comment.
Is it correct to obtain the bytes_size only from one column here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Implement trivial count optimization for Iceberg. Now queries with
count()and without any filters should be faster. Closes #77639.Documentation entry for user-facing changes