Skip to content

Fix reference in lambda callback#78174

Merged
alexkats merged 1 commit intoClickHouse:masterfrom
ianton-ru:dynamic_clusters_autodicovery_fix
Apr 10, 2025
Merged

Fix reference in lambda callback#78174
alexkats merged 1 commit intoClickHouse:masterfrom
ianton-ru:dynamic_clusters_autodicovery_fix

Conversation

@ianton-ru
Copy link
Contributor

@ianton-ru ianton-ru commented Mar 24, 2025 •
edited by alexkats
Loading

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix using reference on local variable

Documentation entry for user-facing changes

Fix of #76001 (comment)

@ianton-ru ianton-ru mentioned this pull request Mar 24, 2025
Merged
@ianton-ru ianton-ru marked this pull request as ready for review March 24, 2025 14:51
@alexkats alexkats self-assigned this Mar 24, 2025
@alexkats alexkats added the can be tested Allows running workflows for external contributors label Mar 24, 2025
@clickhouse-gh
Copy link
Contributor

clickhouse-gh bot commented Mar 24, 2025

Workflow [PR], commit [6af7fd7]

@clickhouse-gh clickhouse-gh bot added the pr-bugfix Pull request with bugfix, not backported by default label Mar 24, 2025
@alexkats alexkats added pr-not-for-changelog This PR should not be mentioned in the changelog and removed pr-bugfix Pull request with bugfix, not backported by default labels Mar 24, 2025
@azat
Copy link
Member

azat commented Mar 24, 2025

Fix using reference on local variable

Hm, AFAICS the problem is not that the variable is local, but the async nature of watches, but anyway, LGTM.

@ianton-ru
Copy link
Contributor Author

ianton-ru commented Apr 10, 2025

Integration tests test_keeper_auth/test.py::test_partial_auth[get_genuine_zk] failed.
Stateless tests failed, I don't fully understand, why. Found only check for logical error:

<Error> void DB::ObjectStorageQueueMetadataFactory::remove(const std::string &, const StorageID &): Code: 49. DB::Exception: Cannot unregister: table \'\''26be6b3b-776c-40dd-98ea-288205b9d37a\'\'' is not registered. (LOGICAL_ERROR), Stack trace (when copying this message, always include the lines below):\\n/var/log/clickhouse-server/clickhouse-server.log:2025.03.24 14:44:57.348553 [ 32036 ] {} <Error> void DB::ObjectStorageQueueMetadataFactory::remove(const std::string &, const StorageID &): Code: 49. DB::Exception: Cannot unregister: table \'\''26be6b3b-776c-40dd-98ea-288205b9d37a\'\'' is not registered. (LOGICAL_ERROR)

I think both fails are not related to this PR.

@alexkats
Copy link
Contributor

alexkats commented Apr 10, 2025

Integration tests (asan, old analyzer, 5/6) - #78981
AST fuzzer (ubsan) - #78542
Stateless tests (release, old analyzer, s3, DatabaseReplicated, 1/2) - #78285
Stress test (tsan) - #77233

@alexkats alexkats added this pull request to the merge queue Apr 10, 2025
Merged via the queue into ClickHouse:master with commit 1ec0277 Apr 10, 2025
117 of 125 checks passed
@robot-clickhouse robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label Apr 10, 2025
@robot-ch-test-poll3 robot-ch-test-poll3 mentioned this pull request Apr 10, 2025
Merged
robot-ch-test-poll3 added a commit that referenced this pull request Apr 10, 2025
@robot-ch-test-poll3
Merge pull request #78983 from ClickHouse/cherrypick/25.3/78174
05fa842 
Cherry pick #78174 to 25.3: Fix reference in lambda callback
robot-clickhouse added a commit that referenced this pull request Apr 10, 2025
@robot-clickhouse
Backport #78174 to 25.3: Fix reference in lambda callback
ad3812e
@robot-ch-test-poll3 robot-ch-test-poll3 mentioned this pull request Apr 10, 2025
Closed
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@azat azat azat approved these changes

+1 more reviewer

@alexkats alexkats alexkats approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@alexkats alexkats

Labels

can be tested Allows running workflows for external contributors pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ianton-ru @azat @alexkats @robot-clickhouse @robot-clickhouse-ci-2