Skip to content

Support partition pruning in DeltaLake engine#78486

Merged
kssenii merged 6 commits intomasterfrom
support-partition-pruning-in-delta-kernel
Apr 3, 2025
Merged

Support partition pruning in DeltaLake engine#78486
kssenii merged 6 commits intomasterfrom
support-partition-pruning-in-delta-kernel

Conversation

@kssenii
Copy link
Member

@kssenii kssenii commented Mar 31, 2025

Contains changes from #78368.

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Support partition pruning in delta lake.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link
Contributor

clickhouse-gh bot commented Mar 31, 2025

Workflow [PR], commit [d65e2ec]

@clickhouse-gh clickhouse-gh bot added the pr-improvement Pull request with some product improvements label Mar 31, 2025
@alesapin alesapin self-assigned this Apr 2, 2025
@kssenii kssenii marked this pull request as ready for review April 2, 2025 13:10
Copy link
Member

@alesapin alesapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

predicate = filter_actions_dag->getOutputs().at(0);
if (getContext()->getSettingsRef()[Setting::use_iceberg_partition_pruning])
{
configuration->implementPartitionPruning(*filter_actions_dag);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get rid of this interface in the next PR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do.

}
}
createIterator(predicate);
createIterator();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like one call inside initializePipeline should be enough?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will try to remove it in a separate PR.

@kssenii
Copy link
Member Author

kssenii commented Apr 3, 2025

Integration tests

test_storage_rabbitmq
test_hedged_requests/test.py::test_combination1

@kssenii kssenii added this pull request to the merge queue Apr 3, 2025
Merged via the queue into master with commit c72b935 Apr 3, 2025
112 of 121 checks passed
@kssenii kssenii deleted the support-partition-pruning-in-delta-kernel branch April 3, 2025 16:45
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Apr 3, 2025
ianton-ru pushed a commit to Altinity/ClickHouse that referenced this pull request Apr 11, 2025
…-pruning-in-delta-kernel

Support partition pruning in DeltaLake engine
ianton-ru pushed a commit to Altinity/ClickHouse that referenced this pull request May 23, 2025
…-pruning-in-delta-kernel

Support partition pruning in DeltaLake engine
@Lucas-PE
Copy link

Hello, I opened the following issue few days ago :
https://github.com/ClickHouse/ClickHouse/issues/79914

It seems delta_kernel_s3 integration has some issues with AWS Region.

Thanks in advance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-improvement Pull request with some product improvements pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants