Skip to content

Fix reading iceberg failed when min-max value is null#78764

Merged
alexey-milovidov merged 4 commits intoClickHouse:masterfrom
ucasfl:fix-iceberg
Apr 8, 2025
Merged

Fix reading iceberg failed when min-max value is null#78764
alexey-milovidov merged 4 commits intoClickHouse:masterfrom
ucasfl:fix-iceberg

Conversation

@ucasfl
Copy link
Collaborator

@ucasfl ucasfl commented Apr 7, 2025

Changelog category (leave one):

  • BugFix

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix reading iceberg table failed when min-max value is NULL. Closes #78740.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link
Contributor

clickhouse-gh bot commented Apr 7, 2025

Workflow [PR], commit [b6acaf8]

@clickhouse-gh clickhouse-gh bot added the pr-improvement Pull request with some product improvements label Apr 7, 2025
@ucasfl ucasfl requested a review from alesapin April 7, 2025 10:50
@alesapin alesapin self-assigned this Apr 7, 2025
@alesapin
Copy link
Member

alesapin commented Apr 7, 2025

Thank you!

@alesapin alesapin added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Apr 7, 2025
Copy link
Member

@alexey-milovidov alexey-milovidov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a test.

@alesapin
Copy link
Member

alesapin commented Apr 7, 2025

@ucasfl @arnaudbriche do you know which engine write bounds with NULL value?

@arnaudbriche
Copy link
Contributor

Metadata has been generated by https://github.com/apache/iceberg-go.

@alesapin
Copy link
Member

alesapin commented Apr 7, 2025

We don't have it in integration tests :( Maybe you know some settings which can force spark to do the same?

@arnaudbriche
Copy link
Contributor

We don't have it in integration tests :( Maybe you know some settings which can force spark to do the same?

Unfortunately no.

@ucasfl
Copy link
Collaborator Author

ucasfl commented Apr 7, 2025

@ucasfl @arnaudbriche do you know which engine write bounds with NULL value?

If all of the values of one column is NULL, it's min-max value in manifest file become NULL.

@ucasfl ucasfl requested a review from alexey-milovidov April 8, 2025 03:31
@Algunenano
Copy link
Member

I think we can close the backports and reclassify this PR to not for changelog. #78764 is not part of any release

@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Apr 9, 2025
ianton-ru pushed a commit to Altinity/ClickHouse that referenced this pull request Apr 15, 2025
Fix reading iceberg failed when min-max value is null
@robot-ch-test-poll robot-ch-test-poll added the pr-backports-created-cloud deprecated label, NOOP label Apr 16, 2025
ianton-ru pushed a commit to Altinity/ClickHouse that referenced this pull request May 23, 2025
Fix reading iceberg failed when min-max value is null
@robot-clickhouse robot-clickhouse added the pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR label Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-improvement Pull request with some product improvements pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Iceberg function now fail on public table (worked until recently)

9 participants