Conversation
Contributor
clickhouse-gh
bot
added
the
pr-not-for-changelog
Member
Author
|
CC @PedroTadim , after this PR fuzzer may want to disable at least one of these two settings when messing with file contents. |
Avogar
reviewed
Apr 11, 2025
Avogar
approved these changes
Apr 11, 2025
Contributor
|
Dear @Avogar, this PR hasn't been updated for a while. You will be unassigned. Will you continue working on it? If so, please feel free to reassign yourself. |
Contributor
|
Workflow [PR], commit [ee30e00] Summary: ❌
|
Member
Author
|
Fuzzer error looks unrelated, and I couldn't reproduce it. It says the query CREATE TABLE source_table (`id` UInt32, `name` String, `value` Float64) ENGINE = MergeTree ORDER BY id;
CREATE TABLE alias_syntax_3__fuzz_27 (`id` LowCardinality(UInt8), `name` Int32, `value` Nullable(Float32)) ENGINE = Alias('source_table') settings allow_suspicious_low_cardinality_types=1;
SELECT murmurHash2_32(isNotNull(2)), * FROM alias_syntax_3__fuzz_27 PREWHERE murmurHash2_32(murmurHash2_32(murmurHash2_32(murmurHash2_32(materialize(toFixedString('', 1)), 1, 1, 1, isNotNull(1), 2, murmurHash3_64(1))), murmurHash2_32(murmurHash2_32(1, 1, materialize(1), isNotNull('')), materialize(2)), 2 <=> 1, isNullable(1), 1, *)) WHERE not(equals(murmurHash2_32(1, '', isNotNull(toLowCardinality(1)), materialize(toUInt128(2)), '\0', 2, 2), isNotNull(2))) ORDER BY ALL ASC NULLS FIRST;failed with |
Member
Author
|
The remaining failed tests are flaky. |
robot-ch-test-poll2
added
the
pr-synced-to-cloud
mkmkme
pushed a commit
to Altinity/ClickHouse
that referenced
this pull request
Dec 16, 2025
Settings to write and verify parquet checksums
mkmkme
added a commit
to Altinity/ClickHouse
that referenced
this pull request
Dec 16, 2025
Settings to write and verify parquet checksums
25 tasks
zvonand
added a commit
to Altinity/ClickHouse
that referenced
this pull request
Dec 20, 2025
Antalya 25.8 Backport of ClickHouse#79012, ClickHouse#87735 and ClickHouse#88827 - Enable parquet reader v3 by default
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Details
output_format_parquet_write_checksums(previously we never wrote checksums),input_format_parquet_verify_checksums(previously we always verified them), simple.