Skip to content

Add a setting to enable/disable dynamic fs cache resize#79148

Merged
kssenii merged 6 commits intomasterfrom
fs-cache-add-setting-to-allow-background-download
Apr 17, 2025
Merged

Add a setting to enable/disable dynamic fs cache resize#79148
kssenii merged 6 commits intomasterfrom
fs-cache-add-setting-to-allow-background-download

Conversation

@kssenii
Copy link
Member

@kssenii kssenii commented Apr 14, 2025

Changelog category (leave one):

  • Backward Incompatible Change

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Add a filesystem cache setting allow_dynamic_cache_resize, by default false, to allow dynamic resize of filesystem cache. Why: in certain environments (ClickHouse Cloud) all the scaling events happen through the restart of the process and we would love this feature to be explicitly disabled to have more control over the behaviour + as a safety measure. This PR is marked as backward incompatible, because in older versions dynamic cache resize worked by default without special setting.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link
Contributor

clickhouse-gh bot commented Apr 14, 2025

Workflow [PR], commit [a1735bc]

@clickhouse-gh clickhouse-gh bot added the pr-backward-incompatible Pull request with backwards incompatible changes label Apr 14, 2025
@vdimir vdimir self-assigned this Apr 16, 2025
@kssenii
Copy link
Member Author

kssenii commented Apr 17, 2025

Integration tests

test_refreshable_mv
test_storage_rabbitmq
-- not related to changes

@kssenii kssenii added this pull request to the merge queue Apr 17, 2025
Merged via the queue into master with commit 8513caa Apr 17, 2025
114 of 123 checks passed
@kssenii kssenii deleted the fs-cache-add-setting-to-allow-background-download branch April 17, 2025 10:47
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Apr 17, 2025
@Algunenano Algunenano mentioned this pull request May 9, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-backward-incompatible Pull request with backwards incompatible changes pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants