Analyzer: Fix wrong results for grouping sets with ColumnConst#79743
Analyzer: Fix wrong results for grouping sets with ColumnConst#79743yakov-olkhovskiy merged 5 commits intoClickHouse:masterfrom
Conversation
0717296 to
aef039d
Compare
|
I do not think this test Firstly, for Nullable data type default value is Null: And the value in output of the test is not null only because original column (ColumnConst in our case) is propagated all the way to output, and the result we see in this test is the default value of the ColumnConst itself (Default value == column value in this case), not its underlying type. So, it is a default value for ColumnConst in this particular case, not for the Enum default value or even a string default value. It used to behave differently before analyzer was introduced, which is correct IMO: https://fiddle.clickhouse.com/a3af412c-582d-42e5-baf1-8f9a7e46b4aa This is also counter-intuitive when comparing it to what docs say: @azat what do you think? https://fiddle.clickhouse.com/654a66cb-ff0a-44ef-9a2e-3925769c4a23 |
b4f8939 to
b64d1b3
Compare
baa7932 to
8fe4ba4
Compare
17ec743 to
48f6c26
Compare
5ba34c2 to
50d31a6
Compare
47d9893 to
fc773bf
Compare
|
@yakov-olkhovskiy the CI is green, PR ready for review |
|
The idea behind this PR is described in the comment above. In a couple of words it is like this: |
Analyzer: Fix wrong results for grouping sets with ColumnConst
24.3.14 Backport of ClickHouse#79743 - Analyzer: Fix wrong results for grouping sets with ColumnConst
Analyzer: Fix wrong results for grouping sets with ColumnConst
25.3.5 Backport of ClickHouse#79743: Fix wrong results for grouping sets with ColumnConst
Analyzer: Fix wrong results for grouping sets with ColumnConst
25.3.6 Backport of ClickHouse#79743: Fix wrong results for grouping sets with ColumnConst
25.3.6 Backport of ClickHouse#79743: Fix wrong results for grouping sets with ColumnConst
Closes #70655.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix wrong results for grouping sets with ColumnConst and Analyzer
Documentation entry for user-facing changes