preserve connection when final empty chunk is left by client#81597
Merged
preserve connection when final empty chunk is left by client#81597
Conversation
Contributor
Member
Author
|
Draft until tests are fixed. |
Michicosun
requested changes
Jun 13, 2025
CheSema
force-pushed
the
chesema-clints-keep-alive
branch
from
e03084a to
5f1d7c0
Compare
Michicosun
approved these changes
Jun 19, 2025
robot-ch-test-poll4
added
the
pr-synced-to-cloud
zvonand
pushed a commit
to Altinity/ClickHouse
that referenced
this pull request
Oct 30, 2025
…ep-alive preserve connection when final empty chunk is left by client
Closed
25 tasks
zvonand
pushed a commit
to Altinity/ClickHouse
that referenced
this pull request
Oct 31, 2025
…ep-alive preserve connection when final empty chunk is left by client
Merged
25 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes are inspired by #81595
This only applies only to the client.
When the response is read, theoretically, the last empty chunk could be left in socket.
Before this changes such connection would be closed, because not data is read.
Here I add an attempt to check that only last empty chunk is left.
And if it is true, the connection is reused, otherwise it is closed.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
preserve connection when final empty chunk is left by client
Documentation entry for user-facing changes