Support references to unknown tables in remote table functions#83844
Merged
Support references to unknown tables in remote table functions#83844
Conversation
Contributor
clickhouse-gh
bot
added
the
pr-bugfix
vdimir
reviewed
Jul 16, 2025
Member
vdimir
left a comment
vdimir
left a comment
There was a problem hiding this comment.
It might be a good idea to add a test for this case, an integration test, at the very least, should be feasible.
| if (table_function_node->getTableFunctionName() == "view") | ||
| { | ||
| auto get_column_options = GetColumnsOptions(GetColumnsOptions::All).withExtendedObjects().withVirtuals(); | ||
| auto column_names_and_types = distributed_storage_snapshot->getColumns(get_column_options); |
Member
There was a problem hiding this comment.
How columns from distributed_storage_snapshot can be different from local analysis of table_function_node in case we have tables on all nodes? Is it the same? What if tables are present on all nodes, but has different structures?
Member
Author
There was a problem hiding this comment.
Table structure can't differ on the shard because it's initialized from the structure request in getStructureOfRemoteTable. And we got in during table function analysis in QueryAnalyzer.
This code solves the problem that in remove(..., view(<>))expression view(<>) is not a resolved query tree and we can't resolve it on the initiator. It was resolved on the shard during the call in getStructureOfRemoteTable.
novikd
commented
Jul 16, 2025
| StorageID remote_storage_id = StorageID::createEmpty(); | ||
| if (!remote_table_function_ptr) | ||
| remote_storage_id = StorageID{remote_database, remote_table}; | ||
| StorageID remote_storage_id = StorageID{remote_database, remote_table}; |
Member
Author
There was a problem hiding this comment.
This is a bit controversial change, because for table functions it is always system.one.
novikd
added
the
pr-must-backport
robot-ch-test-poll3
added
the
pr-synced-to-cloud
robot-ch-test-poll
added
pr-backports-created-cloud
robot-ch-test-poll4
added a commit
that referenced
this pull request
Jul 22, 2025
Cherry pick #83844 to 24.8: Support references to unknown tables in remote table functions
This was referenced Jul 22, 2025
Closed
robot-ch-test-poll4
added a commit
that referenced
this pull request
Jul 22, 2025
Cherry pick #83844 to 25.3: Support references to unknown tables in remote table functions
This was referenced Jul 22, 2025
Merged
robot-ch-test-poll4
added a commit
that referenced
this pull request
Jul 22, 2025
Cherry pick #83844 to 25.4: Support references to unknown tables in remote table functions
This was referenced Jul 22, 2025
Closed
robot-ch-test-poll4
added a commit
that referenced
this pull request
Jul 22, 2025
Cherry pick #83844 to 25.5: Support references to unknown tables in remote table functions
This was referenced Jul 22, 2025
Merged
robot-ch-test-poll4
added a commit
that referenced
this pull request
Jul 22, 2025
Cherry pick #83844 to 25.6: Support references to unknown tables in remote table functions
This was referenced Jul 22, 2025
Merged
robot-ch-test-poll4
added a commit
that referenced
this pull request
Jul 22, 2025
Cherry pick #83844 to 25.7: Support references to unknown tables in remote table functions
robot-ch-test-poll3
added
the
pr-backports-created
clickhouse-gh bot
added a commit
that referenced
this pull request
Jul 22, 2025
Backport #83844 to 25.7: Support references to unknown tables in remote table functions
clickhouse-gh bot
added a commit
that referenced
this pull request
Jul 22, 2025
Backport #83844 to 25.6: Support references to unknown tables in remote table functions
alexey-milovidov
added a commit
that referenced
this pull request
Jul 22, 2025
Backport #83844 to 25.5: Support references to unknown tables in remote table functions
novikd
added a commit
that referenced
this pull request
Jul 29, 2025
Backport #83844 to 25.3: Support references to unknown tables in remote table functions
ianton-ru
pushed a commit
to Altinity/ClickHouse
that referenced
this pull request
Sep 2, 2025
…es in remote table functions
13 tasks
zvonand
added a commit
to Altinity/ClickHouse
that referenced
this pull request
Oct 10, 2025
Backport ClickHouse#83844 to 24.8: Support references to unknown tables in remote table functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Allow referencing any table in
view(...)argument ofremotetable function with enabled analyzer. Fixes #78717. Fixes #79377.Documentation entry for user-facing changes