Skip to content

Fix flaky tests with parquet by partially reverting #82949#84180

Merged
nikitamikhaylov merged 2 commits intoClickHouse:masterfrom
jkartseva:revert-thread-pool-cb-runner-fast-usage
Jul 22, 2025
Merged

Fix flaky tests with parquet by partially reverting #82949#84180
nikitamikhaylov merged 2 commits intoClickHouse:masterfrom
jkartseva:revert-thread-pool-cb-runner-fast-usage

Conversation

@jkartseva
Copy link
Member

@jkartseva jkartseva commented Jul 21, 2025 •
edited by nikitamikhaylov
Loading

Tests with Parquet became flaky, mainly: 00900_long_parquet, 00900_parquet_time_to_ch_date_time, 00900_long_parquet_decimal: https://play.clickhouse.com/play?user=play#U0VMRUNUIGNoZWNrX3N0YXJ0X3RpbWUsIGNoZWNrX25hbWUsIHRlc3RfbmFtZSwgcmVwb3J0X3VybApGUk9NIGNoZWNrcwpXSEVSRSBjaGVja19zdGFydF90aW1lID49IG5vdygpIC0gSU5URVJWQUwgMSBNT05USAogICAgQU5EIChoZWFkX3JlZiA9ICdtYXN0ZXInIEFORCBzdGFydHNXaXRoKGhlYWRfcmVwbywgJ0NsaWNrSG91c2UvJykpCiAgICBBTkQgdGVzdF9zdGF0dXMgIT0gJ1NLSVBQRUQnCiAgICBBTkQgKHRlc3Rfc3RhdHVzIExJS0UgJ0YlJyBPUiB0ZXN0X3N0YXR1cyBMSUtFICdFJScpIAogICAgQU5EIGNoZWNrX3N0YXR1cyAhPSAnc3VjY2VzcycKICAgIEFORCBwb3NpdGlvbih0ZXN0X25hbWUsICdfcGFycXVldCcpID4gMApPUkRFUiBCWSBjaGVja19zdGFydF90aW1l

The main suspect were changes introduced here: #82949 CC @al13n321

Changelog category (leave one):

  • CI Fix or Improvement (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

...

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@jkartseva jkartseva added the can be tested Allows running workflows for external contributors label Jul 21, 2025
@jkartseva jkartseva changed the title Partial revert of https://github.com/ClickHouse/ClickHouse/pull/82949 Partial revert of #82949 Jul 21, 2025
@clickhouse-gh
Copy link
Contributor

clickhouse-gh bot commented Jul 21, 2025 •
edited
Loading

Workflow [PR], commit [fe15096]

Summary: ✅

@jkartseva jkartseva marked this pull request as draft July 21, 2025 22:04
@clickhouse-gh clickhouse-gh bot added the pr-ci label Jul 21, 2025
@jkartseva jkartseva force-pushed the revert-thread-pool-cb-runner-fast-usage branch 4 times, most recently from f0b0b7d to d2eb8b4 Compare July 22, 2025 01:55
@jkartseva jkartseva force-pushed the revert-thread-pool-cb-runner-fast-usage branch from d2eb8b4 to fe15096 Compare July 22, 2025 02:18
@jkartseva jkartseva marked this pull request as ready for review July 22, 2025 04:41
@nikitamikhaylov nikitamikhaylov changed the title Partial revert of #82949 Fix flaky tests with parquet Jul 22, 2025
@nikitamikhaylov nikitamikhaylov changed the title Fix flaky tests with parquet Fix flaky tests with parquet by partially reverting #82949 Jul 22, 2025
@nikitamikhaylov nikitamikhaylov added the 🍃 green ci 🌿 Fixing flaky tests in CI label Jul 22, 2025
@nikitamikhaylov nikitamikhaylov self-assigned this Jul 22, 2025
@nikitamikhaylov nikitamikhaylov added this pull request to the merge queue Jul 22, 2025
Merged via the queue into ClickHouse:master with commit 9d200fa Jul 22, 2025
123 checks passed
@robot-ch-test-poll robot-ch-test-poll added the pr-synced-to-cloud The PR is synced to the cloud repo label Jul 22, 2025
This was referenced Jul 22, 2025
Closed
Closed
@alexey-milovidov alexey-milovidov mentioned this pull request Jul 22, 2025
Closed
baibaichen pushed a commit to Kyligence/ClickHouse that referenced this pull request Jul 28, 2025
@liuneng1994
Support new native parquet reader (#516)
df5df1e 
Fix rebase issue:
- 20250728 ClickHouse#84180
- 20250713 ClickHouse#82949
- 20250703 ClickHouse#82934
- 20250626 ClickHouse#80931
- 20250604 ClickHouse#79649
- 20250502 ClickHouse#79180
- 20250416 ClickHouse#78485
- 20250306 ClickHouse#76662

Co-authored-by: liuneng1994 <[email protected]>
baibaichen pushed a commit to Kyligence/ClickHouse that referenced this pull request Jul 29, 2025
@liuneng1994
Support new native parquet reader (#516)
5696d62 
Fix rebase issue:
- 20250728 ClickHouse#84180
- 20250713 ClickHouse#82949
- 20250703 ClickHouse#82934
- 20250626 ClickHouse#80931
- 20250604 ClickHouse#79649
- 20250502 ClickHouse#79180
- 20250416 ClickHouse#78485
- 20250306 ClickHouse#76662

Co-authored-by: liuneng1994 <[email protected]>
kyligence-git pushed a commit to Kyligence/ClickHouse that referenced this pull request Jul 29, 2025
@liuneng1994
Support new native parquet reader (#516)
7426bad 
Fix rebase issue:
- 20250728 ClickHouse#84180
- 20250713 ClickHouse#82949
- 20250703 ClickHouse#82934
- 20250626 ClickHouse#80931
- 20250604 ClickHouse#79649
- 20250502 ClickHouse#79180
- 20250416 ClickHouse#78485
- 20250306 ClickHouse#76662

Co-authored-by: liuneng1994 <[email protected]>
kyligence-git pushed a commit to Kyligence/ClickHouse that referenced this pull request Jul 30, 2025
@liuneng1994
Support new native parquet reader (#516)
de51fa0 
Fix rebase issue:
- 20250728 ClickHouse#84180
- 20250713 ClickHouse#82949
- 20250703 ClickHouse#82934
- 20250626 ClickHouse#80931
- 20250604 ClickHouse#79649
- 20250502 ClickHouse#79180
- 20250416 ClickHouse#78485
- 20250306 ClickHouse#76662

Co-authored-by: liuneng1994 <[email protected]>
kyligence-git pushed a commit to Kyligence/ClickHouse that referenced this pull request Jul 31, 2025
@liuneng1994
Support new native parquet reader (#516)
5bccde0 
Fix rebase issue:
- 20250728 ClickHouse#84180
- 20250713 ClickHouse#82949
- 20250703 ClickHouse#82934
- 20250626 ClickHouse#80931
- 20250604 ClickHouse#79649
- 20250502 ClickHouse#79180
- 20250416 ClickHouse#78485
- 20250306 ClickHouse#76662

Co-authored-by: liuneng1994 <[email protected]>
kyligence-git pushed a commit to Kyligence/ClickHouse that referenced this pull request Aug 1, 2025
@liuneng1994
Support new native parquet reader (#516)
a7be6f7 
Fix rebase issue:
- 20250728 ClickHouse#84180
- 20250713 ClickHouse#82949
- 20250703 ClickHouse#82934
- 20250626 ClickHouse#80931
- 20250604 ClickHouse#79649
- 20250502 ClickHouse#79180
- 20250416 ClickHouse#78485
- 20250306 ClickHouse#76662

Co-authored-by: liuneng1994 <[email protected]>
kyligence-git pushed a commit to Kyligence/ClickHouse that referenced this pull request Aug 2, 2025
@liuneng1994
Support new native parquet reader (#516)
6954154 
Fix rebase issue:
- 20250728 ClickHouse#84180
- 20250713 ClickHouse#82949
- 20250703 ClickHouse#82934
- 20250626 ClickHouse#80931
- 20250604 ClickHouse#79649
- 20250502 ClickHouse#79180
- 20250416 ClickHouse#78485
- 20250306 ClickHouse#76662

Co-authored-by: liuneng1994 <[email protected]>
kyligence-git pushed a commit to Kyligence/ClickHouse that referenced this pull request Aug 3, 2025
@liuneng1994
Support new native parquet reader (#516)
8b8937f 
Fix rebase issue:
- 20250728 ClickHouse#84180
- 20250713 ClickHouse#82949
- 20250703 ClickHouse#82934
- 20250626 ClickHouse#80931
- 20250604 ClickHouse#79649
- 20250502 ClickHouse#79180
- 20250416 ClickHouse#78485
- 20250306 ClickHouse#76662

Co-authored-by: liuneng1994 <[email protected]>
baibaichen pushed a commit to Kyligence/ClickHouse that referenced this pull request Aug 7, 2025
@liuneng1994
Support new native parquet reader (#516)
c39ed01 
Fix rebase issue:
- 20250806 ClickHouse#84821
- 20250804 ClickHouse#83997
- 20250728 ClickHouse#84180
- 20250713 ClickHouse#82949
- 20250703 ClickHouse#82934
- 20250626 ClickHouse#80931
- 20250604 ClickHouse#79649
- 20250502 ClickHouse#79180
- 20250416 ClickHouse#78485
- 20250306 ClickHouse#76662

Co-authored-by: liuneng1994 <[email protected]>
baibaichen pushed a commit to Kyligence/ClickHouse that referenced this pull request Aug 8, 2025
@liuneng1994
Support new native parquet reader (#516)
4507c94 
Fix rebase issue:
- 20250806 ClickHouse#84821
- 20250804 ClickHouse#83997
- 20250728 ClickHouse#84180
- 20250713 ClickHouse#82949
- 20250703 ClickHouse#82934
- 20250626 ClickHouse#80931
- 20250604 ClickHouse#79649
- 20250502 ClickHouse#79180
- 20250416 ClickHouse#78485
- 20250306 ClickHouse#76662

Co-authored-by: liuneng1994 <[email protected]>
baibaichen pushed a commit to Kyligence/ClickHouse that referenced this pull request Aug 11, 2025
@liuneng1994
Support new native parquet reader (#516)
2e4485d 
Fix rebase issue:
- 20250806 ClickHouse#84821
- 20250804 ClickHouse#83997
- 20250728 ClickHouse#84180
- 20250713 ClickHouse#82949
- 20250703 ClickHouse#82934
- 20250626 ClickHouse#80931
- 20250604 ClickHouse#79649
- 20250502 ClickHouse#79180
- 20250416 ClickHouse#78485
- 20250306 ClickHouse#76662

Co-authored-by: liuneng1994 <[email protected]>
baibaichen pushed a commit to Kyligence/ClickHouse that referenced this pull request Aug 12, 2025
@liuneng1994
Support new native parquet reader (#516)
2f2704d 
Fix rebase issue:
- 20250806 ClickHouse#84821
- 20250804 ClickHouse#83997
- 20250728 ClickHouse#84180
- 20250713 ClickHouse#82949
- 20250703 ClickHouse#82934
- 20250626 ClickHouse#80931
- 20250604 ClickHouse#79649
- 20250502 ClickHouse#79180
- 20250416 ClickHouse#78485
- 20250306 ClickHouse#76662

Co-authored-by: liuneng1994 <[email protected]>
baibaichen pushed a commit to Kyligence/ClickHouse that referenced this pull request Aug 13, 2025
@liuneng1994
Support new native parquet reader (#516)
55bf52d 
Fix rebase issue:
- 20250806 ClickHouse#84821
- 20250804 ClickHouse#83997
- 20250728 ClickHouse#84180
- 20250713 ClickHouse#82949
- 20250703 ClickHouse#82934
- 20250626 ClickHouse#80931
- 20250604 ClickHouse#79649
- 20250502 ClickHouse#79180
- 20250416 ClickHouse#78485
- 20250306 ClickHouse#76662

Co-authored-by: liuneng1994 <[email protected]>
baibaichen pushed a commit to Kyligence/ClickHouse that referenced this pull request Aug 14, 2025
@liuneng1994
Support new native parquet reader (#516)
b411867 
Fix rebase issue:
- 20250806 ClickHouse#84821
- 20250804 ClickHouse#83997
- 20250728 ClickHouse#84180
- 20250713 ClickHouse#82949
- 20250703 ClickHouse#82934
- 20250626 ClickHouse#80931
- 20250604 ClickHouse#79649
- 20250502 ClickHouse#79180
- 20250416 ClickHouse#78485
- 20250306 ClickHouse#76662

Co-authored-by: liuneng1994 <[email protected]>
baibaichen pushed a commit to Kyligence/ClickHouse that referenced this pull request Aug 15, 2025
@liuneng1994
Support new native parquet reader (#516)
c5150b5 
Fix rebase issue:
- 20250806 ClickHouse#84821
- 20250804 ClickHouse#83997
- 20250728 ClickHouse#84180
- 20250713 ClickHouse#82949
- 20250703 ClickHouse#82934
- 20250626 ClickHouse#80931
- 20250604 ClickHouse#79649
- 20250502 ClickHouse#79180
- 20250416 ClickHouse#78485
- 20250306 ClickHouse#76662

Co-authored-by: liuneng1994 <[email protected]>
baibaichen pushed a commit to Kyligence/ClickHouse that referenced this pull request Aug 16, 2025
@liuneng1994
Support new native parquet reader (#516)
93a944c 
Fix rebase issue:
- 20250806 ClickHouse#84821
- 20250804 ClickHouse#83997
- 20250728 ClickHouse#84180
- 20250713 ClickHouse#82949
- 20250703 ClickHouse#82934
- 20250626 ClickHouse#80931
- 20250604 ClickHouse#79649
- 20250502 ClickHouse#79180
- 20250416 ClickHouse#78485
- 20250306 ClickHouse#76662

Co-authored-by: liuneng1994 <[email protected]>
baibaichen pushed a commit to Kyligence/ClickHouse that referenced this pull request Aug 18, 2025
@liuneng1994
Support new native parquet reader (#516)
6db8c8a 
Fix rebase issue:
- 20250806 ClickHouse#84821
- 20250804 ClickHouse#83997
- 20250728 ClickHouse#84180
- 20250713 ClickHouse#82949
- 20250703 ClickHouse#82934
- 20250626 ClickHouse#80931
- 20250604 ClickHouse#79649
- 20250502 ClickHouse#79180
- 20250416 ClickHouse#78485
- 20250306 ClickHouse#76662

Co-authored-by: liuneng1994 <[email protected]>
lgbo-ustc pushed a commit to bigo-sg/ClickHouse that referenced this pull request Sep 17, 2025
@liuneng1994 @lgbo-ustc
Support new native parquet reader (ClickHouse#516)
12d1564 
Fix rebase issue:
- 20250728 ClickHouse#84180
- 20250713 ClickHouse#82949
- 20250703 ClickHouse#82934
- 20250626 ClickHouse#80931
- 20250604 ClickHouse#79649
- 20250502 ClickHouse#79180
- 20250416 ClickHouse#78485
- 20250306 ClickHouse#76662

Co-authored-by: liuneng1994 <[email protected]>
lgbo-ustc pushed a commit to Kyligence/ClickHouse that referenced this pull request Sep 17, 2025
@liuneng1994 @lgbo-ustc
Support new native parquet reader (#516)
277f493 
Fix rebase issue:
- 20250728 ClickHouse#84180
- 20250713 ClickHouse#82949
- 20250703 ClickHouse#82934
- 20250626 ClickHouse#80931
- 20250604 ClickHouse#79649
- 20250502 ClickHouse#79180
- 20250416 ClickHouse#78485
- 20250306 ClickHouse#76662

Co-authored-by: liuneng1994 <[email protected]>
lgbo-ustc pushed a commit to Kyligence/ClickHouse that referenced this pull request Sep 28, 2025
@liuneng1994 @lgbo-ustc
Support new native parquet reader (#516)
c68fb33 
Fix rebase issue:
- 20250728 ClickHouse#84180
- 20250713 ClickHouse#82949
- 20250703 ClickHouse#82934
- 20250626 ClickHouse#80931
- 20250604 ClickHouse#79649
- 20250502 ClickHouse#79180
- 20250416 ClickHouse#78485
- 20250306 ClickHouse#76662

Co-authored-by: liuneng1994 <[email protected]>
zzcclp pushed a commit to Kyligence/ClickHouse that referenced this pull request Dec 19, 2025
@liuneng1994 @zzcclp
Support new native parquet reader (#516)
78e6a27 
Fix rebase issue:
- 20250728 ClickHouse#84180
- 20250713 ClickHouse#82949
- 20250703 ClickHouse#82934
- 20250626 ClickHouse#80931
- 20250604 ClickHouse#79649
- 20250502 ClickHouse#79180
- 20250416 ClickHouse#78485
- 20250306 ClickHouse#76662

Co-authored-by: liuneng1994 <[email protected]>
(cherry picked from commit c68fb33)
zzcclp pushed a commit to Kyligence/ClickHouse that referenced this pull request Dec 25, 2025
@liuneng1994 @zzcclp
Support new native parquet reader (#516)
12ab7a6 
Fix rebase issue:
- 20250728 ClickHouse#84180
- 20250713 ClickHouse#82949
- 20250703 ClickHouse#82934
- 20250626 ClickHouse#80931
- 20250604 ClickHouse#79649
- 20250502 ClickHouse#79180
- 20250416 ClickHouse#78485
- 20250306 ClickHouse#76662

Co-authored-by: liuneng1994 <[email protected]>
(cherry picked from commit c68fb33)
zzcclp pushed a commit to Kyligence/ClickHouse that referenced this pull request Mar 10, 2026
@liuneng1994 @zzcclp
Support new native parquet reader (#516)
b0e53bd 
Fix rebase issue:
- 20250728 ClickHouse#84180
- 20250713 ClickHouse#82949
- 20250703 ClickHouse#82934
- 20250626 ClickHouse#80931
- 20250604 ClickHouse#79649
- 20250502 ClickHouse#79180
- 20250416 ClickHouse#78485
- 20250306 ClickHouse#76662

Co-authored-by: liuneng1994 <[email protected]>
(cherry picked from commit c68fb33)
(cherry picked from commit 12ab7a6)
zzcclp pushed a commit to Kyligence/ClickHouse that referenced this pull request Mar 11, 2026
@liuneng1994 @zzcclp
Support new native parquet reader (#516)
8cc1b47 
Fix rebase issue:
- 20250728 ClickHouse#84180
- 20250713 ClickHouse#82949
- 20250703 ClickHouse#82934
- 20250626 ClickHouse#80931
- 20250604 ClickHouse#79649
- 20250502 ClickHouse#79180
- 20250416 ClickHouse#78485
- 20250306 ClickHouse#76662

Co-authored-by: liuneng1994 <[email protected]>
(cherry picked from commit c68fb33)
(cherry picked from commit 12ab7a6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikitamikhaylov nikitamikhaylov nikitamikhaylov approved these changes

Assignees

@nikitamikhaylov nikitamikhaylov

Labels

can be tested Allows running workflows for external contributors 🍃 green ci 🌿 Fixing flaky tests in CI pr-ci pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jkartseva @nikitamikhaylov @robot-ch-test-poll @rschu1ze