Limit disks to search for orphaned parts by ilejn · Pull Request #84710 · ClickHouse/ClickHouse

ilejn · 2025-07-30T09:18:12Z

Changelog category (leave one):

Improvement

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

New MergeTree setting search_orphaned_parts_drives to limit scope to look for parts e.g. by disks with local metadata.

Fixes: #70514

src/Storages/MergeTree/MergeTreeData.h

src/Storages/MergeTree/MergeTreeData.cpp

src/Interpreters/DatabaseCatalog.cpp

tests/integration/test_search_detached_parts/test.py

src/Core/SettingsChangesHistory.cpp

src/Core/SettingsEnums.h

src/Interpreters/DatabaseCatalog.cpp

src/Storages/MergeTree/MergeTreeData.cpp

tests/integration/test_search_orphaned_parts/configs/storage_conf.xml

src/Storages/MergeTree/MergeTreeData.h

tests/integration/test_search_orphaned_parts/test.py

src/Storages/MergeTree/MergeTreeData.cpp

ilejn · 2025-08-05T09:26:35Z

CH is not able to start if s3 is not available and s3 disk with plain_rewritable metadata is configured.
https://pastila.nl/?00314508/95c6b93efc0152bc16406a0c3d4eddc1#e1OEKKuCGwcIWUy941a3Zw==
I'd like to leave it out of the scope of this PR and investigate later.

tests/integration/test_search_orphaned_parts/configs/storage_conf.xml

…onf.xml

src/Interpreters/DatabaseCatalog.cpp

clickhouse-gh · 2025-08-05T13:14:47Z

Workflow [PR], commit [84f91fd]

Summary: ❌

job_name	test_name	status
Integration tests (aarch64, distributed plan, 4/4)		failure
	test_storage_rabbitmq/test.py::test_rabbitmq_address	FAIL
	test_storage_rabbitmq/test.py::test_rabbitmq_msgpack	FAIL
Stress test (amd_debug)		failure
	Server died	FAIL
	Hung check failed, possible deadlock found (see hung_check.log)	FAIL
	Killed by signal (in clickhouse-server.log)	FAIL
	Fatal message in clickhouse-server.log (see fatal_messages.txt)	FAIL
	Killed by signal (output files)	FAIL
	Found signal in gdb.log	FAIL

azat · 2025-08-06T08:06:10Z

Tests has failed, @ilejn PTAL

ilejn · 2025-08-06T14:32:24Z

Something about settings changes history.
Trace

2025.08.06 14:09:04.930748 [ 777 ] {} <Error> Application: Code: 170. DB::Exception: Bad get: has UInt64, requested String. (BAD_GET), Stack trace (when copying this message, always include the lines below):

0. /home/ilejn/projects/ClickHouse_search_orphaned_parts/contrib/llvm-project/libcxx/include/__exception/exception.h:113: Poco::Exception::Exception(String const&, int) @ 0x000000001e145f72
1. /home/ilejn/projects/ClickHouse_search_orphaned_parts/src/Common/Exception.cpp:116: DB::Exception::Exception(DB::Exception::MessageMasked&&, int, bool) @ 0x00000000108024db
2. /home/ilejn/projects/ClickHouse_search_orphaned_parts/src/Common/Exception.h:119: DB::Exception::Exception(PreformattedMessage&&, int) @ 0x00000000097e826c
3. /home/ilejn/projects/ClickHouse_search_orphaned_parts/src/Common/Exception.h:137: DB::Exception::Exception<std::basic_string_view<char, std::char_traits<char>>, std::basic_string_view<char, std::char_traits<char>>>(int, FormatStringHelperImpl<std::type_identity<std::basic_string_view<char, std::char_traits<char>>>::type, std::type_identity<std::basic_string_view<char, std::char_traits<char>>>::type>, std::basic_string_view<char, std::char_traits<char>>&&, std::basic_string_view<char, std::char_traits<char>>&&) @ 0x0000000014ccc22b
4. /home/ilejn/projects/ClickHouse_search_orphaned_parts/src/Core/Field.cpp:874: DB::NearestFieldTypeImpl<__decay(String), void>::Type& DB::Field::safeGet<String>() & @ 0x0000000014ccd2ab
5. /home/ilejn/projects/ClickHouse_search_orphaned_parts/src/Core/Field.h:437: DB::SettingFieldEnum<DB::SearchOrphanedPartsDisks, DB::SettingFieldSearchOrphanedPartsDisksTraits>::SettingFieldEnum(DB::Field const&) @ 0x00000000190f01cc
6. /home/ilejn/projects/ClickHouse_search_orphaned_parts/src/Storages/MergeTree/MergeTreeSettings.cpp:1915: DB::MergeTreeSettingsTraits::Accessor::instance()::$_0::operator()() const::'lambda501'(DB::Field const&)::__invoke(DB::Field const&) @ 0x00000000190e7f52
7. /home/ilejn/projects/ClickHouse_search_orphaned_parts/src/Storages/MergeTree/MergeTreeSettings.cpp:1890: DB::MergeTreeSettings::applyCompatibilitySetting(String const&) @ 0x00000000190af7ce
8. /home/ilejn/projects/ClickHouse_search_orphaned_parts/src/Interpreters/Context.cpp:5409: DB::Context::getMergeTreeSettings() const @ 0x0000000015ed1352
9. /home/ilejn/projects/ClickHouse_search_orphaned_parts/programs/server/Server.cpp:837: DB::(anonymous namespace)::sanityChecks(DB::Server&) @ 0x0000000010b312ad

Probably I misunderstand semantic somehow

        addSettingsChanges(merge_tree_settings_changes_history, "25.8",
        {
            {"search_orphaned_parts_disks", SearchOrphanedPartsDisks::ANY, SearchOrphanedPartsDisks::ANY, "New setting"},

ilejn · 2025-08-06T14:56:07Z

Hm ... it seems it should be
{"search_orphaned_parts_disks", "any", "any"

Rechecking.

ilejn · 2025-08-06T22:48:07Z

Observing exactly the same issue in other PR https://play.clickhouse.com/play?user=play#c2VsZWN0ICogZnJvbSBjaGVja3Mgd2hlcmUgcHVsbF9yZXF1ZXN0X251bWJlcj04MzA5NCBhbmQgdGVzdF9uYW1lPScwMTE1NF9tb3ZlX3BhcnRpdGlvbl9sb25nJyBhbmQgY2hlY2tfc3RhcnRfdGltZSA+ICcyMDI1LTA3LTA3JyBhbmQgY2hlY2tfc3RhdHVzPSdmYWlsdXJlJyBvcmRlciBieSBjaGVja19zdGFydF90aW1lIGRlc2MgbGltaXQgMTA7Cg==

azat · 2025-08-07T06:17:57Z

CH Inc sync - Waiting for status to be reported — Conflicts found. The sync PR is not mergeable, it probably has conflicts

Conflicts has been resolved

ilejn · 2025-08-07T06:54:16Z

Test failures are new (did not exist while previous run).
It seems that test_storage_delta is flaky, while I will look into it.

ilejn · 2025-08-07T13:25:40Z

I cannot say anything meaningful about the nature of test_storage_delta failures,
but they are not related to the PR.

azat · 2025-08-07T14:42:16Z

CI:

02126_dist_desc - flaky
test_storage_delta - flaky - test_storage_delta is flaky #85209

tests/integration/test_search_orphaned_parts/test.py

azat · 2025-08-07T21:10:57Z

CI:

Limit disks to search for orphaned parts

24.8.14 Backport of ClickHouse#84710: Limit disks to search for orphaned parts

* partial ported from ClickHouse/ClickHouse#84710 * ignore no_such_file_or_directory during dropAllData

ilejn added 6 commits July 25, 2025 20:26

search_orphaned_parts: before switch to MergeTreeSettings

7784fca

search_orphaned_parts: slightly works

5d2da49

search_orphaned_parts: drop improved

acfe152

Merge remote-tracking branch 'origin/master' into search_orphaned_parts

d2327dc

search_orphaned_parts: get rid of WRITEABLE, extra tests

6ff6733

search_orphaned_parts: cleanup

8dcbf94

ilejn changed the title ~~Limit disk to search for parts~~ Limit disks to search for parts Jul 30, 2025

arthurpassos reviewed Jul 30, 2025

View reviewed changes

ilejn added 2 commits July 31, 2025 22:19

search_orphaned_parts: detached=>orphaned, improvements per code review

3a28286

Merge remote-tracking branch 'origin/master' into search_orphaned_parts

9f9ef86

ilejn changed the title ~~Limit disks to search for parts~~ Limit disks to search for orphaned parts Aug 4, 2025

azat self-assigned this Aug 4, 2025

azat requested changes Aug 4, 2025

View reviewed changes

azat reviewed Aug 4, 2025

View reviewed changes

src/Storages/MergeTree/MergeTreeData.cpp Outdated Show resolved Hide resolved

azat mentioned this pull request Aug 4, 2025

Implement missing APIs for DiskEncrypted #85028

Merged

search_orphaned_parts: changes per code review, test refactored

85aa0ce

azat reviewed Aug 5, 2025

View reviewed changes

tests/integration/test_search_orphaned_parts/configs/storage_conf.xml Show resolved Hide resolved

azat reviewed Aug 5, 2025

View reviewed changes

tests/integration/test_search_orphaned_parts/configs/storage_conf.xml Show resolved Hide resolved

Update tests/integration/test_search_orphaned_parts/configs/storage_c…

fca62ca

…onf.xml

azat reviewed Aug 5, 2025

View reviewed changes

src/Interpreters/DatabaseCatalog.cpp Outdated Show resolved Hide resolved

azat reviewed Aug 5, 2025

View reviewed changes

src/Interpreters/DatabaseCatalog.cpp Outdated Show resolved Hide resolved

search_orphaned_parts: changes per code review (2)

859fc3e

azat approved these changes Aug 5, 2025

View reviewed changes

azat added the can be tested Allows running workflows for external contributors label Aug 5, 2025

clickhouse-gh bot added the pr-improvement Pull request with some product improvements label Aug 5, 2025

search_orphaned_parts: missed file added

ad2ecf6

Merge remote-tracking branch 'origin/master' into search_orphaned_parts

f5921ee

search_orphaned_parts: string in SettingsChangesHistory

1502979

Merge remote-tracking branch 'origin/master' into search_orphaned_parts

e885408

azat reviewed Aug 7, 2025

View reviewed changes

tests/integration/test_search_orphaned_parts/test.py Show resolved Hide resolved

Update tests/integration/test_search_orphaned_parts/test.py

84f91fd

azat enabled auto-merge August 7, 2025 21:11

azat added this pull request to the merge queue Aug 7, 2025

Merged via the queue into ClickHouse:master with commit a130149 Aug 7, 2025
121 of 124 checks passed

robot-ch-test-poll4 added the pr-synced-to-cloud The PR is synced to the cloud repo label Aug 7, 2025

ilejn pushed a commit to Altinity/ClickHouse that referenced this pull request Aug 25, 2025

Merge pull request ClickHouse#84710 from ilejn/search_orphaned_parts

3aa85ab

Limit disks to search for orphaned parts

zvonand mentioned this pull request Oct 9, 2025

24.8.14 Backport of #84710: Limit disks to search for orphaned parts Altinity/ClickHouse#977

Merged

zvonand added a commit to Altinity/ClickHouse that referenced this pull request Oct 10, 2025

Merge pull request #977 from Altinity/backports/24.8.14/84710

1681701

24.8.14 Backport of ClickHouse#84710: Limit disks to search for orphaned parts

zvonand mentioned this pull request Oct 16, 2025

24.8.14 Stable Pre-release PR Altinity/ClickHouse#1085

Merged

yl-lisen added a commit to timeplus-io/proton that referenced this pull request Oct 29, 2025

skip access unused disks during dropping stream

c27ac02

* partial ported from ClickHouse/ClickHouse#84710 * ignore no_such_file_or_directory during dropAllData

Conversation

ilejn commented Jul 30, 2025 • edited by azat Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog category (leave one):

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ilejn commented Aug 5, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

clickhouse-gh bot commented Aug 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azat commented Aug 6, 2025

Uh oh!

ilejn commented Aug 6, 2025

Uh oh!

ilejn commented Aug 6, 2025

Uh oh!

ilejn commented Aug 6, 2025

Uh oh!

azat commented Aug 7, 2025

Uh oh!

ilejn commented Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ilejn commented Aug 7, 2025

Uh oh!

azat commented Aug 7, 2025

Uh oh!

Uh oh!

azat commented Aug 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ilejn commented Jul 30, 2025 •

edited by azat

Loading

clickhouse-gh bot commented Aug 5, 2025 •

edited

Loading

ilejn commented Aug 7, 2025 •

edited

Loading