Skip to content

Add missing partition_columns_in_data_file to azure configuration#85373

Merged
kssenii merged 2 commits intoClickHouse:masterfrom
arthurpassos:patch-3
Aug 13, 2025
Merged

Add missing partition_columns_in_data_file to azure configuration#85373
kssenii merged 2 commits intoClickHouse:masterfrom
arthurpassos:patch-3

Conversation

@arthurpassos
Copy link
Contributor

@arthurpassos arthurpassos commented Aug 11, 2025

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Add missing partition_columns_in_data_file to azure configuration.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@arthurpassos
Copy link
Contributor Author

arthurpassos commented Aug 11, 2025

cc @PedroTadim @kssenii

@arthurpassos arthurpassos mentioned this pull request Aug 11, 2025
Merged
1 task
@PedroTadim
Copy link
Member

PedroTadim commented Aug 11, 2025

Add test please 😄

@PedroTadim
Copy link
Member

PedroTadim commented Aug 11, 2025

Just to confirm, these new options can't be used in the table function versions, right?

@arthurpassos
Copy link
Contributor Author

arthurpassos commented Aug 11, 2025

You can use it in the insert ... s3(..., partition_strategy=...), but you should not be able to use it in a select query.

@kssenii kssenii self-assigned this Aug 11, 2025
@arthurpassos
Copy link
Contributor Author

arthurpassos commented Aug 11, 2025

Added tests for azure named collections with partition_columns_in_data_file=0|1. Can you guys enable CI?

@clickhouse-gh
Copy link
Contributor

clickhouse-gh bot commented Aug 11, 2025 •
edited
Loading

Workflow [PR], commit [8198161]

Summary: ❌

job_name test_name status info comment
Stateless tests (amd_tsan, s3 storage, parallel) failure
02443_detach_attach_partition FAIL
Integration tests (asan, old analyzer, 3/6) failure
test_throttling/test.py::test_remote_write_throttling_reload FAIL
Stress test (arm_asan) failure
Server died FAIL
Hung check failed, possible deadlock found (see hung_check.log) FAIL
Killed by signal (in clickhouse-server.log) FAIL
Fatal message in clickhouse-server.log (see fatal_messages.txt) FAIL
Killed by signal (output files) FAIL

@clickhouse-gh clickhouse-gh bot added the pr-improvement Pull request with some product improvements label Aug 11, 2025
@arthurpassos
Copy link
Contributor Author

arthurpassos commented Aug 11, 2025

'can be tested' label is required

@kssenii kssenii added the can be tested Allows running workflows for external contributors label Aug 12, 2025
@kssenii
Copy link
Member

kssenii commented Aug 13, 2025

Stress test

#84669

@kssenii kssenii added this pull request to the merge queue Aug 13, 2025
Merged via the queue into ClickHouse:master with commit c0c4ffd Aug 13, 2025
238 of 242 checks passed
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kssenii kssenii kssenii approved these changes

Assignees

@kssenii kssenii

Labels

can be tested Allows running workflows for external contributors pr-improvement Pull request with some product improvements pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@arthurpassos @PedroTadim @kssenii @robot-ch-test-poll2