Skip to content

Fix inferring Date/DateTime/DateTime64 on dates that are out of supported range#86184

Merged
Avogar merged 8 commits intoClickHouse:masterfrom
Avogar:bad-date-inference
Sep 23, 2025
Merged

Fix inferring Date/DateTime/DateTime64 on dates that are out of supported range#86184
Avogar merged 8 commits intoClickHouse:masterfrom
Avogar:bad-date-inference

Conversation

@Avogar
Copy link
Member

@Avogar Avogar commented Aug 26, 2025

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Fix inferring Date/DateTime/DateTime64 on dates that are out of supported range.

Closes #86025

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link
Contributor

clickhouse-gh bot commented Aug 26, 2025 •
edited
Loading

Workflow [PR], commit [a0495c2]

Summary: ❌

job_name test_name status info comment
Stateless tests (amd_binary, ParallelReplicas, s3 storage, parallel) failure
03300_nested_json_empty_keys FAIL
Exception in test runner FAIL
Killed by signal (in clickhouse-server.log or clickhouse-server.err.log) FAIL
Fatal messages (in clickhouse-server.log or clickhouse-server.err.log) FAIL
Bugfix validation (integration tests) failure
Stress test (amd_tsan) failure
Server died FAIL
Hung check failed, possible deadlock found (see hung_check.log) FAIL
Killed by signal (in clickhouse-server.log) FAIL
Fatal message in clickhouse-server.log (see fatal_messages.txt) FAIL
Killed by signal (output files) FAIL
Found signal in gdb.log FAIL
Stress test (arm_asan) failure
Server died FAIL
Hung check failed, possible deadlock found (see hung_check.log) FAIL
Killed by signal (in clickhouse-server.log) FAIL
Fatal message in clickhouse-server.log (see fatal_messages.txt) FAIL
Killed by signal (output files) FAIL

@clickhouse-gh clickhouse-gh bot added the pr-bugfix Pull request with bugfix, not backported by default label Aug 26, 2025
@bharatnc bharatnc self-assigned this Sep 3, 2025
bharatnc
bharatnc reviewed Sep 6, 2025
View reviewed changes
bharatnc
bharatnc reviewed Sep 6, 2025
View reviewed changes
@Avogar
Copy link
Member Author

Avogar commented Sep 23, 2025

Stateless tests (amd_binary, ParallelReplicas, s3 storage, parallel) and Stress test (amd_tsan) - #87467
Bugfix validation (integration tests) - for some reason it tested updated integration test and not the new sql test
Stress test (arm_asan) - #83988

@Avogar Avogar added this pull request to the merge queue Sep 23, 2025
Merged via the queue into ClickHouse:master with commit 85a99eb Sep 23, 2025
118 of 123 checks passed
@Avogar Avogar deleted the bad-date-inference branch September 23, 2025 19:04
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Sep 23, 2025
@Avogar Avogar added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Oct 21, 2025
This was referenced Oct 21, 2025
Closed
Merged
robot-ch-test-poll1 added a commit that referenced this pull request Oct 21, 2025
@robot-ch-test-poll1
Merge pull request #88845 from ClickHouse/cherrypick/25.7/86184
db3246c 
Cherry pick #86184 to 25.7: Fix inferring Date/DateTime/DateTime64 on dates that are out of supported range
robot-clickhouse added a commit that referenced this pull request Oct 21, 2025
@robot-clickhouse
Backport #86184 to 25.7: Fix inferring Date/DateTime/DateTime64 on da…
3eef943 
…tes that are out of supported range
This was referenced Oct 21, 2025
Closed
Merged
robot-ch-test-poll1 added a commit that referenced this pull request Oct 21, 2025
@robot-ch-test-poll1
Merge pull request #88847 from ClickHouse/cherrypick/25.8/86184
dd513a6 
Cherry pick #86184 to 25.8: Fix inferring Date/DateTime/DateTime64 on dates that are out of supported range
robot-clickhouse added a commit that referenced this pull request Oct 21, 2025
@robot-clickhouse
Backport #86184 to 25.8: Fix inferring Date/DateTime/DateTime64 on da…
27f3f97 
…tes that are out of supported range
This was referenced Oct 21, 2025
Merged
Merged
robot-ch-test-poll1 added a commit that referenced this pull request Oct 21, 2025
@robot-ch-test-poll1
Merge pull request #88849 from ClickHouse/cherrypick/25.9/86184
01b995e 
Cherry pick #86184 to 25.9: Fix inferring Date/DateTime/DateTime64 on dates that are out of supported range
robot-clickhouse added a commit that referenced this pull request Oct 21, 2025
@robot-clickhouse
Backport #86184 to 25.9: Fix inferring Date/DateTime/DateTime64 on da…
7a0d63c 
…tes that are out of supported range
@robot-ch-test-poll1 robot-ch-test-poll1 mentioned this pull request Oct 21, 2025
Merged
clickhouse-gh bot added a commit that referenced this pull request Oct 21, 2025
@clickhouse-gh
Merge pull request #88848 from ClickHouse/backport/25.8/86184
35b8f5b 
Backport #86184 to 25.8: Fix inferring Date/DateTime/DateTime64 on dates that are out of supported range
@robot-clickhouse robot-clickhouse added pr-backports-created-cloud deprecated label, NOOP pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR labels Oct 21, 2025
Avogar added a commit that referenced this pull request Oct 30, 2025
@Avogar
Merge pull request #88850 from ClickHouse/backport/25.9/86184
fe9c38d 
Backport #86184 to 25.9: Fix inferring Date/DateTime/DateTime64 on dates that are out of supported range
@robot-clickhouse robot-clickhouse added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Oct 30, 2025
@Avogar Avogar mentioned this pull request Dec 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bharatnc bharatnc bharatnc approved these changes

Assignees

@bharatnc bharatnc

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Strings with dates less then 1970-01-01 are infered as Date time and saved as 1970-01-01 in text formats schema inference

4 participants

@Avogar @bharatnc @robot-clickhouse @robot-clickhouse-ci-1