Fix table name encoding in data lake rest catalog#87020
Merged
alexey-milovidov merged 4 commits intoClickHouse:masterfrom Oct 20, 2025
Merged
Fix table name encoding in data lake rest catalog#87020alexey-milovidov merged 4 commits intoClickHouse:masterfrom
alexey-milovidov merged 4 commits intoClickHouse:masterfrom
Conversation
scanhex12
added
the
can be tested
Contributor
clickhouse-gh
bot
added
the
pr-bugfix
Contributor
Author
|
Build amd_release fails with strange notice: Looks like CI issue |
13 tasks
Contributor
|
Dear @scanhex12, this PR hasn't been updated for a while. You will be unassigned. Will you continue working on it? If so, please feel free to reassign yourself. |
| const auto & context = getContext(); | ||
|
|
||
| Poco::URI url(base_url / endpoint); | ||
| Poco::URI url(base_url / endpoint, false); |
| const auto table_name = current_table_json->get("name").extract<String>(); | ||
| const auto table_name_raw = current_table_json->get("name").extract<String>(); | ||
| std::string table_name; | ||
| Poco::URI::encode(table_name_raw, "/", table_name); |
| } | ||
|
|
||
| Poco::URI url(endpoint); | ||
| Poco::URI url(endpoint, false); |
Contributor
Author
|
Comments are added. |
alexey-milovidov
approved these changes
Oct 20, 2025
ianton-ru
pushed a commit
to Altinity/ClickHouse
that referenced
this pull request
Nov 6, 2025
…_encode Fix table name encoding in data lake rest catalog
Merged
25 tasks
scanhex12
added
v25.8-must-backport
pr-must-backport
robot-ch-test-poll4
added
the
pr-must-backport-synced
This was referenced Dec 23, 2025
scanhex12
added a commit
that referenced
this pull request
Dec 23, 2025
Cherry pick #87020 to 25.8: Fix table name encoding in data lake rest catalog
robot-clickhouse
added a commit
that referenced
this pull request
Dec 23, 2025
scanhex12
added a commit
that referenced
this pull request
Dec 23, 2025
Backport #87020 to 25.8: Fix table name encoding in data lake rest catalog
robot-ch-test-poll1
added
the
pr-backports-created
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Fix data lake tables with a percent-encoded sequence in the name. Closes #86626.
Documentation entry for user-facing changes
Solved #86626
Clickhouse can't work with data lake tables when table name contains encoded sequence '%2F'.
This PR allows to work with these tables.
It's not clear what is a correct way, to interpret names as 'a/b' or 'a%2Fb', this PR makes second option.