Multiple disks/volumes for storing data for send in Distributed engine#8756
Merged
alexey-milovidov merged 2 commits intoClickHouse:masterfrom Jan 25, 2020
Merged
Conversation
azat
commented
Jan 20, 2020
azat
force-pushed
the
distributed_storage_configuration
branch
4 times, most recently
from
9b920e7 to
8b4b65d
Compare
azat
changed the title
Member
Author
|
#8750 had been merged, this PR rebased against master (WIP dropped) |
Member
Author
|
azat
force-pushed
the
distributed_storage_configuration
branch
from
8b4b65d to
bfe6931
Compare
Member
Author
Even though I cannot reproduce it when running manually, it fails constantly on CI, digging into logs |
Now Distributed() has gain the 5-th argument -- policy name (for storing data to send): CREATE TABLE foo (key Int) Engine=Distributed(test_shard_localhost, currentDatabase(), some_table, key%2, 'default');
azat
force-pushed
the
distributed_storage_configuration
branch
from
bfe6931 to
5c641b7
Compare
Member
Author
(The reason it passed in my setup is due to stalled build objects) |
alexey-milovidov
approved these changes
Jan 25, 2020
azat
added a commit
to azat/ClickHouse
that referenced
this pull request
Apr 19, 2020
…ibuted sends After ClickHouse#8756 the problem with 1 thread for each (distributed table, disk) for distributed sends became even worse (since there can be multiple disks), so use predefined thread pool for this tasks, that can be controlled with background_distributed_schedule_pool_size knob.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (up to few sentences, required except for Non-significant/Documentation categories):
Multiple disks/volumes for storing data for send in Distributed engine
Detailed description (optional):
Usage example:
Follow-up: #4918
v2: use
storage_policyover introducing separatedistributed_storage_policy