Skip to content

Fix handling of timestamp(tz) columns in Glue Catalog#87733

Merged
scanhex12 merged 4 commits intoClickHouse:masterfrom
zvonand:zvonand-fix-87609
Oct 1, 2025
Merged

Fix handling of timestamp(tz) columns in Glue Catalog#87733
scanhex12 merged 4 commits intoClickHouse:masterfrom
zvonand:zvonand-fix-87609

Conversation

@zvonand
Copy link
Contributor

@zvonand zvonand commented Sep 26, 2025 •
edited
Loading

Closes #87609

Test introduced in #83132 was green, but it does not work with "real" AWS (as stated in the issue above)

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Fix handling of timestamp / timestamptz columns in Glue

@zvonand zvonand changed the title Fix #87609: Fix handling of timestamp(tz) columns in Glue Fix handling of timestamp(tz) columns in Glue Sep 26, 2025
@zvonand
Copy link
Contributor Author

zvonand commented Sep 26, 2025

@scanhex12 maybe you could take a look (as you are the author of the original code) ?

@zvonand zvonand changed the title Fix handling of timestamp(tz) columns in Glue Fix handling of timestamp(tz) columns in Glue Catalog Sep 27, 2025
@scanhex12 scanhex12 self-assigned this Sep 27, 2025
@scanhex12 scanhex12 added the can be tested Allows running workflows for external contributors label Sep 27, 2025
@clickhouse-gh
Copy link
Contributor

clickhouse-gh bot commented Sep 27, 2025 •
edited
Loading

Workflow [PR], commit [1d0dc77]

Summary: ❌

job_name test_name status info comment
Stateless tests (amd_debug, AsyncInsert, s3 storage, parallel) failure
03212_variant_dynamic_cast_or_default FAIL
Integration tests (amd_tsan, 3/6) failure
test_storage_iceberg_schema_evolution/test_evolved_schema_simple.py::test_evolved_schema_simple[True-local-1] FAIL
test_storage_iceberg_schema_evolution/test_evolved_schema_simple.py::test_evolved_schema_simple[False-azure-2] FAIL
test_storage_iceberg_schema_evolution/test_evolved_schema_simple.py::test_evolved_schema_simple[True-s3-1] FAIL
test_storage_iceberg_schema_evolution/test_evolved_schema_simple.py::test_evolved_schema_simple[False-s3-2] FAIL
test_storage_iceberg_schema_evolution/test_evolved_schema_simple.py::test_evolved_schema_simple[False-local-2] FAIL
test_storage_iceberg_schema_evolution/test_evolved_schema_simple.py::test_evolved_schema_simple[True-azure-2] FAIL
test_storage_iceberg_schema_evolution/test_evolved_schema_simple.py::test_evolved_schema_simple[True-s3-2] FAIL
test_storage_iceberg_schema_evolution/test_evolved_schema_simple.py::test_evolved_schema_simple[False-s3-1] FAIL
test_storage_iceberg_schema_evolution/test_evolved_schema_simple.py::test_evolved_schema_simple[False-local-1] FAIL
test_storage_iceberg_schema_evolution/test_evolved_schema_simple.py::test_evolved_schema_simple[False-azure-1] FAIL
test_storage_iceberg_schema_evolution/test_evolved_schema_simple.py::test_evolved_schema_simple[True-azure-1] FAIL
test_storage_iceberg_schema_evolution/test_evolved_schema_simple.py::test_evolved_schema_simple[True-local-2] FAIL
test_parts_delete_zookeeper/test.py::test_merge_doesnt_work_without_zookeeper FAIL
test_storage_iceberg_no_spark/test_writes_statistics_by_minmax_pruning.py::test_writes_statistics_by_minmax_pruning[azure-1] FAIL
test_storage_iceberg_no_spark/test_writes_statistics_by_minmax_pruning.py::test_writes_statistics_by_minmax_pruning[local-2] FAIL
test_storage_iceberg_no_spark/test_writes_statistics_by_minmax_pruning.py::test_writes_statistics_by_minmax_pruning[local-1] FAIL
test_storage_iceberg_no_spark/test_writes_statistics_by_minmax_pruning.py::test_writes_statistics_by_minmax_pruning[azure-2] FAIL
test_storage_iceberg_no_spark/test_writes_statistics_by_minmax_pruning.py::test_writes_statistics_by_minmax_pruning[s3-2] FAIL
test_storage_iceberg_no_spark/test_writes_statistics_by_minmax_pruning.py::test_writes_statistics_by_minmax_pruning[s3-1] FAIL
test_insert_into_distributed_through_materialized_view/test.py::test_inserts_local FAIL
test_insert_into_distributed_through_materialized_view/test.py::test_reconnect FAIL
Finish Workflow failure
python3 ./ci/jobs/scripts/workflow_hooks/new_tests_check.py failure

@clickhouse-gh clickhouse-gh bot added the pr-bugfix Pull request with bugfix, not backported by default label Sep 27, 2025
@scanhex12
Copy link
Member

scanhex12 commented Sep 27, 2025

@zvonand Thanks for the fix

@zvonand zvonand force-pushed the zvonand-fix-87609 branch 2 times, most recently from 3e16432 to 2b6a02b Compare September 28, 2025 22:33
@zvonand
Copy link
Contributor Author

zvonand commented Sep 29, 2025

None of the fails seem to be related:

@zvonand
Copy link
Contributor Author

zvonand commented Sep 29, 2025

@scanhex12 could you please take a look / approve once again?

@zvonand zvonand requested a review from scanhex12 September 29, 2025 14:04
@zvonand
Copy link
Contributor Author

zvonand commented Oct 1, 2025

@scanhex12 gentle ping

@zvonand zvonand mentioned this pull request Oct 1, 2025
Merged
13 tasks
@scanhex12 scanhex12 enabled auto-merge October 1, 2025 21:20
@scanhex12 scanhex12 added this pull request to the merge queue Oct 1, 2025
Merged via the queue into ClickHouse:master with commit 95c1985 Oct 1, 2025
119 of 123 checks passed
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-synced-to-cloud The PR is synced to the cloud repo label Oct 1, 2025
@Enmk Enmk mentioned this pull request Nov 21, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scanhex12 scanhex12 Awaiting requested review from scanhex12

Assignees

@scanhex12 scanhex12

Labels

can be tested Allows running workflows for external contributors pr-bugfix Pull request with bugfix, not backported by default pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

GlueCatalog fails with "Host is empty in S3 URI. (BAD_ARGUMENTS)" for each Iceberg table

3 participants

@zvonand @scanhex12 @robot-ch-test-poll4