Conversation
Contributor
|
Workflow [PR], commit [4c02439] Summary: ❌
|
rienath
reviewed
Oct 20, 2025
Member
rienath
left a comment
There was a problem hiding this comment.
Thanks for the wait, here's the review. One minor general comment: Parquet improvements deserve to be in the changelog. Let's change the category
8981abc to
3eb1602
Compare
rienath
approved these changes
Oct 21, 2025
vitlibar
reviewed
Nov 1, 2025
| @@ -0,0 +1,52 @@ | |||
| #!/usr/bin/env bash | |||
mkmkme
pushed a commit
to Altinity/ClickHouse
that referenced
this pull request
Dec 16, 2025
A few more parquet fixes
25 tasks
zvonand
added a commit
to Altinity/ClickHouse
that referenced
this pull request
Dec 20, 2025
Antalya 25.8 Backport of ClickHouse#79012, ClickHouse#87735 and ClickHouse#88827 - Enable parquet reader v3 by default
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
In parquet writer, emit
created_bystring in correct format, e.g.ClickHouse version 25.10.1 (build 5b1dfb14925db8901a4e9202cd5d63c11ecfbb9f)instead ofClickHouse v25.9.1.1-testing.Fix parquet reader compatibility with bad files written by old parquet-mr.
This PR is stacked on top of #87600 , review only commits starting from "A few more parquet fixes".
Closes #87306
created_bystring in correct format (according toparquet.thrift):ClickHouse version 25.10.1 (build 5b1dfb14925db8901a4e9202cd5d63c11ecfbb9f)instead ofClickHouse v25.9.1.1-testing.clickhouse-testfailing ifdiffoutput is not valid utf8.00900_long_parquet_load.shwith00900_long_parquet_load_2.shthat:data_parquet/..referencefile needs to be updated whenever a file is added todata_parquet/or schema inference logic changes.