tests: fix port overlap in ytsaurus tests#88134
Closed
azat wants to merge 1 commit intoClickHouse:masterfrom
Closed
tests: fix port overlap in ytsaurus tests#88134azat wants to merge 1 commit intoClickHouse:masterfrom
azat wants to merge 1 commit intoClickHouse:masterfrom
Conversation
Contributor
clickhouse-gh
bot
added
the
pr-not-for-changelog
Contributor
|
@azat If you don't mind, I can do a pr with fix |
antaljanosbenjamin
approved these changes
Oct 6, 2025
Member
Author
|
@MikhailBurdukov you are welcome! (ping me there). |
Member
Author
|
BTW please also take a look into this - ClickHouse/tests/integration/test_ytsaurus/yt_helpers.py Lines 133 to 136 in bfc360e And also you don't need to expose ports (and this is actually what all integration tests should do to avoid port overlaps, but I remember there are some issues with kafka) if you are doing requests via container host |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
CI: https://s3.amazonaws.com/clickhouse-test-reports/json.html?PR=88105&sha=7a9ea0741cd64ec11f96818b9c8d02fb296c87ce&name_0=PR&name_1=Integration%20tests%20%28amd_binary%2C%204%2F5%29
Cc @MikhailBurdukov