Cherry pick #79969 to 25.3: Fix match(col, '^…') index analysis with escaped metacharacters to avoid wrong results and crashes#89328
Merged
robot-ch-test-poll3 merged 6 commits intobackport/25.3/79969from Oct 31, 2025
Conversation
- Change loop to `while (pos < end)` to guard against overruns - Support all single‐char escapes: `\]`, `\}`, `\-`, `\\` alongside existing metachars - Move `++pos` into the supported‐escape case only, removing stray increments - Prevent garbage reads past `end` and ensure correct fixed‐prefix for escaped metacharacters
Co-authored-by: Pervakov Grigorii <[email protected]>
Fix match(col, '^…') index analysis with escaped metacharacters to avoid wrong results and crashes
robot-ch-test-poll3
added
pr-cherrypick
robot-ch-test-poll3
merged commit 09185ad
into
backport/25.3/79969
125 of 131 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original pull-request #79969
Do not merge this PR manually
This pull-request is a first step of an automated backporting.
It contains changes similar to calling
git cherry-picklocally.If you intend to continue backporting the changes, then resolve all conflicts if any.
Otherwise, if you do not want to backport them, then just close this pull-request.
The check results does not matter at this step - you can safely ignore them.
Troubleshooting
If the conflicts were resolved in a wrong way
If this cherry-pick PR is completely screwed by a wrong conflicts resolution, and you want to recreate it:
pr-cherrypicklabel from the PRYou also need to check the Original pull-request for
pr-backports-createdlabel, and delete if it's presented thereThe PR source
The PR is created in the CI job