Crash in IN function where columns have different types and many columns are involved#89367
Merged
KochetovNicolai merged 7 commits intoClickHouse:masterfrom Nov 13, 2025
Merged
Conversation
Contributor
Author
|
Query The thing about the query - match between (Account, Symbol) and (Symbol, Account) which is UInt32 against String. Some (not all) Symbol values can be casted to UInt32. Backtrace The version is close to recent master. |
Contributor
Author
|
I have a repro, but it is not a small one, so I don't think that it make sense to create a test based on it. |
ilejn
changed the title
ilejn
changed the title
Contributor
Author
|
Hello, |
Contributor
Author
|
Hello @KochetovNicolai , |
Contributor
|
Workflow [PR], commit [5d4d21b] Summary: ❌
|
clickhouse-gh
bot
added
the
pr-bugfix
| { | ||
| /// We cannot afford filtering rows because | ||
| /// sortBlock relies on equal number of rows in all columns | ||
| transformed_set_columns[set_element_index] = std::move(nullable_set_column); |
Member
There was a problem hiding this comment.
This does not look correct to me. I think the code is written in a way that tuple columns and PK columns must have the same type, and we have to apply a cast in one or another way.
The proper solution seems to be creating a common nullmask. Because if one tuple component can't be converted to desired PK type, the whole tuple can't match.
Contributor
Author
There was a problem hiding this comment.
Hello @KochetovNicolai , thank you for looking into this.
What we are doing here is exactly applying cast
ColumnPtr nullable_set_column = castColumnAccurateOrNull({set_column, set_element_type, {}}, key_column_type);
...
if (set_columns.size() > 1)
{
transformed_set_columns[set_element_index] = std::move(nullable_set_column);
continue;
What we are not doing is applying filter.
Does it make sense?
Regarding 'creating a common nullmask' , I agree, it looks like a mature approach. I hesitated to go this way, because it makes the fix a bit more complex.
If you like, I can do this in another PR or switch to it in this PR.
KochetovNicolai
requested changes
Nov 7, 2025
Contributor
Author
|
Hello @KochetovNicolai , One of the test failures is caused by this PR, it must be listed in parallel_replicas_blacklist.txt . Others seem not related. |
KochetovNicolai
approved these changes
Nov 12, 2025
Contributor
Author
Merged
via the queue into
ClickHouse:master
with commit Nov 13, 2025
33a028c
251 of 256 checks passed
ilejn
pushed a commit
to Altinity/ClickHouse
that referenced
this pull request
Nov 19, 2025
Crash in IN function where columns have different types and many columns are involved
zvonand
pushed a commit
to Altinity/ClickHouse
that referenced
this pull request
Dec 8, 2025
Crash in IN function where columns have different types and many columns are involved
25 tasks
zvonand
pushed a commit
to Altinity/ClickHouse
that referenced
this pull request
Dec 15, 2025
Crash in IN function where columns have different types and many columns are involved
zvonand
added a commit
to Altinity/ClickHouse
that referenced
this pull request
Dec 17, 2025
25.8.12 Backport of ClickHouse#89367: Crash in IN function where columns have different types and many columns are involved
zvonand
added a commit
to Altinity/ClickHouse
that referenced
this pull request
Dec 23, 2025
25.8.12 Backport of ClickHouse#89367: Crash in IN function where columns have different types and many columns are involved
25 tasks
zvonand
added a commit
to Altinity/ClickHouse
that referenced
this pull request
Dec 25, 2025
25.8.13 Backport of ClickHouse#89367: Crash in IN function where columns have different types and many columns are involved
zvonand
added a commit
to Altinity/ClickHouse
that referenced
this pull request
Jan 15, 2026
25.8.13 Backport of ClickHouse#89367: Crash in IN function where columns have different types and many columns are involved
25 tasks
zvonand
added a commit
to Altinity/ClickHouse
that referenced
this pull request
Jan 27, 2026
25.8.13 Backport of ClickHouse#89367: Crash in IN function where columns have different types and many columns are involved
25 tasks
zvonand
added a commit
to Altinity/ClickHouse
that referenced
this pull request
Jan 28, 2026
25.8.15 Backport of ClickHouse#89367: Crash in IN function where columns have different types and many columns are involved
25 tasks
zvonand
added a commit
to Altinity/ClickHouse
that referenced
this pull request
Feb 9, 2026
…in_in_function 24.8.14 Backport of ClickHouse#89367 - Crash in IN function where columns have different types and many columns are involved
zvonand
pushed a commit
to Altinity/ClickHouse
that referenced
this pull request
Feb 18, 2026
Crash in IN function where columns have different types and many columns are involved
25 tasks
zvonand
pushed a commit
to Altinity/ClickHouse
that referenced
this pull request
Mar 17, 2026
Crash in IN function where columns have different types and many columns are involved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Possible crash/undefined behavior in IN function where primary key column types are different from IN function right side column types. Example: SELECT string_column, int_column FROM test_table WHERE (string_column, int_column) IN (SELECT '5', 'not a number'). Appears if many rows are selected and there are rows contain not compatible types.