Add blockSerializedSize() function (size on disk without compression)#8952
Merged
alexey-milovidov merged 2 commits intoClickHouse:masterfrom Feb 3, 2020
Merged
Add blockSerializedSize() function (size on disk without compression)#8952alexey-milovidov merged 2 commits intoClickHouse:masterfrom
alexey-milovidov merged 2 commits intoClickHouse:masterfrom
Conversation
azat
force-pushed
the
getSerializedSize
branch
from
f0a04e8 to
2dd6c35
Compare
Member
|
This function is very specific. It works on blocks rather than individual values that is very confusing. Maybe name it |
azat
force-pushed
the
getSerializedSize
branch
from
2dd6c35 to
e1a07ab
Compare
Member
Author
Indeed, nice catch, thanks!
Done |
azat
changed the title
Member
|
Ok. Almost ready.
|
azat
force-pushed
the
getSerializedSize
branch
2 times, most recently
from
c5bddeb to
de5766b
Compare
Sometimes it is useful to know how much does this data will take on disk, with blockSerializedSize() you can know this (although without compression). This can be a major knowledge for various aggregation functions that tracking some state (i.e. uniqCombined).
azat
force-pushed
the
getSerializedSize
branch
from
de5766b to
e89ceae
Compare
Member
Author
Agree, done |
alexey-milovidov
approved these changes
Feb 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add blockSerializedSize() function (size on disk without compression)
Detailed description / Documentation draft:
Sometimes it is useful to know how much does this data will take on
disk, with blockSerializedSize() you can know this (although without
compression).
This can be a major knowledge for various aggregation functions that
tracking some state (i.e.
uniqCombined).P.S. not sure that this is the best naming though, hence any suggestions are welcome! At first I was thinking about
getSizeOf(), but this can be confused with size in memory, while they are differs