Skip to content

Unblock ttl part drops for cold volumes#90059

Merged
Michicosun merged 6 commits intomasterfrom
unblock_ttl_drop_merges_in_cold_volumes
Nov 21, 2025
Merged

Unblock ttl part drops for cold volumes#90059
Michicosun merged 6 commits intomasterfrom
unblock_ttl_drop_merges_in_cold_volumes

Conversation

@Michicosun
Copy link
Member

@Michicosun Michicosun commented Nov 14, 2025 •
edited
Loading

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Split part ranges by volume characteristics to enable TTL drop merges for cold volumes. After this patch, parts with a max TTL < now will be removed from cold storage. The algorithm will schedule only single part drops.

Fixes #85636.

@Michicosun Michicosun marked this pull request as ready for review November 14, 2025 15:38
@clickhouse-gh
Copy link
Contributor

clickhouse-gh bot commented Nov 14, 2025 •
edited
Loading

Workflow [PR], commit [1fa6b9e]

Summary: ❌

job_name test_name status info comment
Integration tests (amd_asan, old analyzer, 3/6) failure
test_ytsaurus/test_dictionaries.py::test_yt_dictionary_id[False-FLAT] FAIL cidb
test_ytsaurus/test_dictionaries.py::test_yt_dictionary_id[True-FLAT] FAIL cidb
test_ytsaurus/test_dictionaries.py::test_yt_dictionary_id[False-HASHED] FAIL cidb
test_ytsaurus/test_dictionaries.py::test_yt_dictionary_id[True-HASHED] FAIL cidb
test_ytsaurus/test_dictionaries.py::test_yt_dictionary_id[False-HASHED_ARRAY] FAIL cidb
test_ytsaurus/test_dictionaries.py::test_yt_dictionary_id[True-HASHED_ARRAY] FAIL cidb
test_ytsaurus/test_dictionaries.py::test_yt_dictionary_complex_key[True-COMPLEX_KEY_HASHED] FAIL cidb
test_ytsaurus/test_dictionaries.py::test_yt_dictionary_complex_key[False-COMPLEX_KEY_HASHED] FAIL cidb
test_ytsaurus/test_dictionaries.py::test_yt_dictionary_complex_key[True-COMPLEX_KEY_HASHED_ARRAY] FAIL cidb
test_ytsaurus/test_dictionaries.py::test_yt_dictionary_complex_key[False-COMPLEX_KEY_HASHED_ARRAY] FAIL cidb
9 more test cases not shown
BuzzHouse (amd_debug) failure
Buzzing result failure cidb
BuzzHouse (amd_tsan) failure
Buzzing result failure cidb

@clickhouse-gh clickhouse-gh bot added the pr-bugfix Pull request with bugfix, not backported by default label Nov 14, 2025
@CurtizJ CurtizJ self-assigned this Nov 14, 2025
@Michicosun Michicosun changed the title Unblock ttl drop merges in cold volumes Unblock ttl part drops for cold volumes Nov 14, 2025
@Michicosun
Copy link
Member Author

Michicosun commented Nov 14, 2025

Needs #90077

@Michicosun Michicosun mentioned this pull request Nov 17, 2025
Closed
@Michicosun Michicosun added this pull request to the merge queue Nov 21, 2025
Merged via the queue into master with commit 77bf5e0 Nov 21, 2025
126 of 130 checks passed
@Michicosun Michicosun deleted the unblock_ttl_drop_merges_in_cold_volumes branch November 21, 2025 15:48
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Nov 21, 2025
@aalexfvk
Copy link
Contributor

aalexfvk commented Nov 24, 2025

@Michicosun What do you think about backporting this ?

@Michicosun
Copy link
Member Author

Michicosun commented Nov 24, 2025

@aalexfvk What versions do you use?

@aalexfvk
Copy link
Contributor

aalexfvk commented Dec 15, 2025

@aalexfvk What versions do you use?

All starting from 25.3

@OhJuhun OhJuhun mentioned this pull request Feb 2, 2026
Open
zvonand pushed a commit to Altinity/ClickHouse that referenced this pull request Feb 3, 2026
@Michicosun @zvonand
Merge pull request ClickHouse#90059 from ClickHouse/unblock_ttl_drop_…
016b43a 
…merges_in_cold_volumes

Unblock ttl part drops for cold volumes
@zvonand zvonand mentioned this pull request Feb 3, 2026
Merged
25 tasks
zvonand pushed a commit to Altinity/ClickHouse that referenced this pull request Feb 5, 2026
@Michicosun @zvonand
Merge pull request ClickHouse#90059 from ClickHouse/unblock_ttl_drop_…
17cd534 
…merges_in_cold_volumes

Unblock ttl part drops for cold volumes
MyroTk added a commit to Altinity/ClickHouse that referenced this pull request Feb 6, 2026
@MyroTk
Merge pull request #1363 from Altinity/backports/25.8.15/90059
dba4ab3 
25.8.16 Stable Backport of ClickHouse#90059: Unblock ttl part drops for cold volumes
@ku524 ku524 mentioned this pull request Feb 24, 2026
Open
@aalexfvk
Copy link
Contributor

aalexfvk commented Mar 16, 2026

@Michicosun
Hello! Just a reminder about the backport.

@Michicosun
Copy link
Member Author

Michicosun commented Mar 16, 2026

@aalexfvk We decided not to backport because it is too risky. Please upgrade to 25.12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CurtizJ CurtizJ CurtizJ approved these changes

Assignees

@CurtizJ CurtizJ

Labels

pr-bugfix Pull request with bugfix, not backported by default pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TTLDelete + ttl_only_drop_parts does not work for volumes with prefer_not_to_merge=true

5 participants

@Michicosun @aalexfvk @CurtizJ @robot-ch-test-poll2 @svb-alt