Skip to content

Fix a bug about toDateTimeOrNull with negative argument#90490

Merged
yariks5s merged 24 commits intomasterfrom
yarik/fix-todatetime-null-bug
Dec 9, 2025
Merged

Fix a bug about toDateTimeOrNull with negative argument#90490
yariks5s merged 24 commits intomasterfrom
yarik/fix-todatetime-null-bug

Conversation

@yariks5s
Copy link
Member

@yariks5s yariks5s commented Nov 20, 2025 •
edited by clickhouse-gh bot
Loading

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Fixes a bug where toDateTimeOrNull of a negative argument returns NULL.

@clickhouse-gh
Copy link
Contributor

clickhouse-gh bot commented Nov 20, 2025 •
edited
Loading

Workflow [PR], commit [b9d11e6]

Summary: ❌

job_name test_name status info comment
Stateless tests (amd_msan, parallel) failure
00816_long_concurrent_alter_column FAIL cidb, issue
03403_mv_errors FAIL cidb, issue
Integration tests (amd_tsan, 1/6) failure
test_storage_nats/test_nats_jet_stream.py::test_nats_overloaded_insert FAIL cidb, issue
BuzzHouse (amd_debug) failure
Logical error: 'Inconsistent AST formatting in Function_arrayElement: the query: FAIL cidb, issue
BuzzHouse (amd_tsan) failure
Segmentation fault (STID: 3075-3638) FAIL cidb

@clickhouse-gh clickhouse-gh bot added the pr-bugfix Pull request with bugfix, not backported by default label Nov 20, 2025
@yariks5s yariks5s marked this pull request as draft November 20, 2025 13:22
@yariks5s
Provide a flag to control saturation.
bf374fa
@yariks5s
Merge branch 'master' into yarik/fix-todatetime-null-bug
1e120db
@yariks5s
Fix build
fe45048
@yariks5s
Fix build
d5ffe92
@yariks5s
Fix the fast tests
3f5dfcd
@yariks5s
Merge branch 'yarik/fix-todatetime-null-bug' of https://github.com/Cl…
b35cb02 
…ickHouse/ClickHouse into yarik/fix-todatetime-null-bug
@yariks5s
Fix fast tests
97523cd
@yariks5s
Merge branch 'master' into yarik/fix-todatetime-null-bug
d97891e
@yariks5s
Fix after conflict
911ba31
@yariks5s
tidy build
f3036a0
@yariks5s
Merge branch 'yarik/fix-todatetime-null-bug' of https://github.com/Cl…
7401a16 
…ickHouse/ClickHouse into yarik/fix-todatetime-null-bug
@yariks5s
Merge remote-tracking branch 'origin/master' into yarik/fix-todatetim…
d633f3a 
…e-null-bug
@yariks5s
revert last change.
ea96d95
@yariks5s
Fix the fast tests
e4eec79
@yariks5s
Merge branch 'master' into yarik/fix-todatetime-null-bug
77e57f4
@yariks5s
Merge branch 'master' into yarik/fix-todatetime-null-bug
e0fb9b1
@yariks5s yariks5s marked this pull request as ready for review December 2, 2025 15:45
Avogar
Avogar reviewed Dec 3, 2025
View reviewed changes
Avogar
Avogar reviewed Dec 3, 2025
View reviewed changes
Avogar
Avogar reviewed Dec 3, 2025
View reviewed changes
Avogar
Avogar reviewed Dec 3, 2025
View reviewed changes
Avogar
Avogar reviewed Dec 3, 2025
View reviewed changes
@alsugiliazova
Copy link
Contributor

alsugiliazova commented Dec 4, 2025

This pr will also fix this #87601

This was referenced Dec 10, 2025
Closed
Merged
robot-ch-test-poll3 added a commit that referenced this pull request Dec 10, 2025
@robot-ch-test-poll3
Merge pull request #91869 from ClickHouse/cherrypick/25.8/90490
e941386 
Cherry pick #90490 to 25.8: Fix a bug about `toDateTimeOrNull` with negative argument
robot-clickhouse added a commit that referenced this pull request Dec 10, 2025
@robot-clickhouse
Backport #90490 to 25.8: Fix a bug about toDateTimeOrNull with nega…
3db28c4 
…tive argument
This was referenced Dec 10, 2025
Merged
Merged
robot-ch-test-poll3 added a commit that referenced this pull request Dec 10, 2025
@robot-ch-test-poll3
Merge pull request #91871 from ClickHouse/cherrypick/25.9/90490
403d8b4 
Cherry pick #90490 to 25.9: Fix a bug about `toDateTimeOrNull` with negative argument
robot-clickhouse added a commit that referenced this pull request Dec 10, 2025
@robot-clickhouse
Backport #90490 to 25.9: Fix a bug about toDateTimeOrNull with nega…
e4609d0 
…tive argument
This was referenced Dec 10, 2025
Merged
Merged
robot-ch-test-poll3 added a commit that referenced this pull request Dec 10, 2025
@robot-ch-test-poll3
Merge pull request #91873 from ClickHouse/cherrypick/25.10/90490
cbb67f8 
Cherry pick #90490 to 25.10: Fix a bug about `toDateTimeOrNull` with negative argument
robot-clickhouse added a commit that referenced this pull request Dec 10, 2025
@robot-clickhouse
Backport #90490 to 25.10: Fix a bug about toDateTimeOrNull with neg…
dbb01e7 
…ative argument
This was referenced Dec 10, 2025
Merged
Merged
robot-ch-test-poll3 added a commit that referenced this pull request Dec 10, 2025
@robot-ch-test-poll3
Merge pull request #91875 from ClickHouse/cherrypick/25.11/90490
a541300 
Cherry pick #90490 to 25.11: Fix a bug about `toDateTimeOrNull` with negative argument
robot-clickhouse added a commit that referenced this pull request Dec 10, 2025
@robot-clickhouse
Backport #90490 to 25.11: Fix a bug about toDateTimeOrNull with neg…
027b416 
…ative argument
@robot-ch-test-poll3 robot-ch-test-poll3 mentioned this pull request Dec 10, 2025
Merged
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Dec 10, 2025
clickhouse-gh bot added a commit that referenced this pull request Dec 10, 2025
@clickhouse-gh
Merge pull request #91876 from ClickHouse/backport/25.11/90490
a1e5361 
Backport #90490 to 25.11: Fix a bug about `toDateTimeOrNull` with negative argument
clickhouse-gh bot added a commit that referenced this pull request Dec 10, 2025
@clickhouse-gh
Merge pull request #91872 from ClickHouse/backport/25.9/90490
fee8e8a 
Backport #90490 to 25.9: Fix a bug about `toDateTimeOrNull` with negative argument
yariks5s added a commit that referenced this pull request Dec 10, 2025
@yariks5s
Merge pull request #91874 from ClickHouse/backport/25.10/90490
6ea2912 
Backport #90490 to 25.10: Fix a bug about `toDateTimeOrNull` with negative argument
yariks5s added a commit that referenced this pull request Dec 10, 2025
@yariks5s
Merge pull request #91870 from ClickHouse/backport/25.8/90490
4227fc5 
Backport #90490 to 25.8: Fix a bug about `toDateTimeOrNull` with negative argument
zvonand added a commit to Altinity/ClickHouse that referenced this pull request Dec 14, 2025
@zvonand
Merge pull request #1206 from Altinity/backports/antalya-25.8/90490
20ca39f 
Antalya 25.8 Backport of ClickHouse#90490: Fix a bug about `toDateTimeOrNull` with negative argument
@zvonand zvonand mentioned this pull request Dec 14, 2025
Merged
25 tasks
zvonand pushed a commit to Altinity/ClickHouse that referenced this pull request Dec 15, 2025
@yariks5s @zvonand
Merge pull request ClickHouse#91870 from ClickHouse/backport/25.8/90490
03c361d 
Backport ClickHouse#90490 to 25.8: Fix a bug about `toDateTimeOrNull` with negative argument
@zvonand zvonand mentioned this pull request Dec 15, 2025
Merged
25 tasks
@fm4v
Copy link
Member

fm4v commented Dec 15, 2025

@yariks5s is it backward incompatible change?

@Avogar
Copy link
Member

Avogar commented Dec 15, 2025

No it's not. #86184 was and this PR reverts back most of the changed behaviour that could lead to changes in user queries.

@fm4v
Copy link
Member

fm4v commented Dec 15, 2025

@Avogar thanks!

zvonand added a commit to Altinity/ClickHouse that referenced this pull request Dec 17, 2025
@zvonand
Merge pull request #1225 from Altinity/backports/25.8.12/91870
1d2e117 
25.8.12 Stable backport of ClickHouse#90490: Fix a bug about `toDateTimeOrNull` with negative argument
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Avogar Avogar Avogar approved these changes

Assignees

@Avogar Avogar

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@yariks5s @alsugiliazova @fm4v @Avogar @robot-ch-test-poll2 @robot-ch-test-poll4 @robot-clickhouse-ci-1