Skip to content

Fix access validation for ALTER UPDATE with remote table function#90761

Merged
pufit merged 5 commits intomasterfrom
pufit/fix-access-alter-with-remote
Dec 8, 2025
Merged

Fix access validation for ALTER UPDATE with remote table function#90761
pufit merged 5 commits intomasterfrom
pufit/fix-access-alter-with-remote

Conversation

@pufit
Copy link
Member

@pufit pufit commented Nov 24, 2025

Changelog category (leave one):

  • Critical Bug Fix (crash, data loss, RBAC) or LOGICAL_ERROR

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Fix access validation for ALTER UPDATE queries when a remote table function is used with localhost as a target host.

@clickhouse-gh
Copy link
Contributor

clickhouse-gh bot commented Nov 24, 2025 •
edited
Loading

Workflow [PR], commit [6097f69]

Summary: ❌

job_name test_name status info comment
Stateless tests (arm_asan, targeted) failure
03222_datetime64_small_value_const FAIL cidb
Stateless tests (amd_tsan, s3 storage, parallel) failure
03212_variant_dynamic_cast_or_default FAIL cidb, issue
Stress test (amd_msan) failure
Server died FAIL cidb
Hung check failed, possible deadlock found (see hung_check.log) FAIL cidb
Killed by signal (in clickhouse-server.log) FAIL cidb
Fatal message in clickhouse-server.log (see fatal_messages.txt) FAIL cidb
Killed by signal (output files) FAIL cidb
Found signal in gdb.log FAIL cidb
BuzzHouse (amd_debug) failure
Logical error: 'Inconsistent AST formatting: the query: FAIL cidb, issue
BuzzHouse (amd_ubsan) failure
UndefinedBehaviorSanitizer: undefined behavior (STID: 4443-3aa0) FAIL cidb

@clickhouse-gh clickhouse-gh bot added pr-critical-bugfix pr-must-backport Pull request should be backported intentionally. Use this label with great care! labels Nov 24, 2025
@SmitaRKulkarni SmitaRKulkarni self-assigned this Nov 25, 2025
SmitaRKulkarni
SmitaRKulkarni approved these changes Dec 2, 2025
View reviewed changes
Copy link
Member

@SmitaRKulkarni SmitaRKulkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pufit pufit added this pull request to the merge queue Dec 8, 2025
Merged via the queue into master with commit ea11d54 Dec 8, 2025
124 of 130 checks passed
@pufit pufit deleted the pufit/fix-access-alter-with-remote branch December 8, 2025 22:56
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Dec 8, 2025
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR label Dec 8, 2025
This was referenced Dec 8, 2025
Merged
Merged
robot-ch-test-poll3 added a commit that referenced this pull request Dec 8, 2025
@robot-ch-test-poll3
Merge pull request #91753 from ClickHouse/cherrypick/25.8/90761
196ba6e 
Cherry pick #90761 to 25.8: Fix access validation for ALTER UPDATE with `remote` table function
@robot-ch-test-poll3 robot-ch-test-poll3 mentioned this pull request Dec 8, 2025
Merged
robot-clickhouse added a commit that referenced this pull request Dec 8, 2025
@robot-clickhouse
Backport #90761 to 25.8: Fix access validation for ALTER UPDATE with …
b9a0def 
…`remote` table function
@robot-ch-test-poll3 robot-ch-test-poll3 mentioned this pull request Dec 8, 2025
Merged
robot-ch-test-poll3 added a commit that referenced this pull request Dec 8, 2025
@robot-ch-test-poll3
Merge pull request #91755 from ClickHouse/cherrypick/25.9/90761
6d77bf4 
Cherry pick #90761 to 25.9: Fix access validation for ALTER UPDATE with `remote` table function
robot-clickhouse added a commit that referenced this pull request Dec 8, 2025
@robot-clickhouse
Backport #90761 to 25.9: Fix access validation for ALTER UPDATE with …
6775ff0 
…`remote` table function
This was referenced Dec 8, 2025
Closed
Merged
robot-ch-test-poll3 added a commit that referenced this pull request Dec 8, 2025
@robot-ch-test-poll3
Merge pull request #91757 from ClickHouse/cherrypick/25.10/90761
9e3403b 
Cherry pick #90761 to 25.10: Fix access validation for ALTER UPDATE with `remote` table function
robot-clickhouse added a commit that referenced this pull request Dec 8, 2025
@robot-clickhouse
Backport #90761 to 25.10: Fix access validation for ALTER UPDATE with…
6398898 
… `remote` table function
This was referenced Dec 8, 2025
Merged
Merged
robot-ch-test-poll3 added a commit that referenced this pull request Dec 8, 2025
@robot-ch-test-poll3
Merge pull request #91759 from ClickHouse/cherrypick/25.11/90761
f7d5da9 
Cherry pick #90761 to 25.11: Fix access validation for ALTER UPDATE with `remote` table function
robot-clickhouse added a commit that referenced this pull request Dec 8, 2025
@robot-clickhouse
Backport #90761 to 25.11: Fix access validation for ALTER UPDATE with…
f276df3 
… `remote` table function
@robot-ch-test-poll3 robot-ch-test-poll3 mentioned this pull request Dec 8, 2025
Merged
pufit added a commit that referenced this pull request Dec 17, 2025
@pufit
Merge pull request #91752 from ClickHouse/cherrypick/25.3/90761
e5f2886 
Cherry pick #90761 to 25.3: Fix access validation for ALTER UPDATE with `remote` table function
pufit added a commit that referenced this pull request Dec 17, 2025
@pufit
Merge pull request #91760 from ClickHouse/backport/25.11/90761
6562421 
Backport #90761 to 25.11: Fix access validation for ALTER UPDATE with `remote` table function
robot-clickhouse added a commit that referenced this pull request Dec 17, 2025
@robot-clickhouse
Backport #90761 to 25.3: Fix access validation for ALTER UPDATE with …
ab24f13 
…`remote` table function
@robot-clickhouse robot-clickhouse mentioned this pull request Dec 17, 2025
Merged
@robot-ch-test-poll robot-ch-test-poll added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Dec 17, 2025
clickhouse-gh bot added a commit that referenced this pull request Dec 17, 2025
@clickhouse-gh
Merge pull request #91758 from ClickHouse/backport/25.10/90761
7e69b1c 
Backport #90761 to 25.10: Fix access validation for ALTER UPDATE with `remote` table function
zvonand pushed a commit to Altinity/ClickHouse that referenced this pull request Dec 24, 2025
@pufit @zvonand
Merge pull request ClickHouse#90761 from ClickHouse/pufit/fix-access-…
21a913f 
…alter-with-remote

Fix access validation for ALTER UPDATE with `remote` table function
@zvonand zvonand mentioned this pull request Dec 24, 2025
Merged
25 tasks
zvonand added a commit to Altinity/ClickHouse that referenced this pull request Dec 27, 2025
@zvonand
Merge pull request #1256 from Altinity/backports/25.8.13/90761
a4ce138 
25.8.13 Stable backport of ClickHouse#90761: Fix access validation for ALTER UPDATE with `remote` table function
zvonand pushed a commit to Altinity/ClickHouse that referenced this pull request Jan 15, 2026
@pufit @zvonand
Merge pull request ClickHouse#90761 from ClickHouse/pufit/fix-access-…
6d4b9b2 
…alter-with-remote

Fix access validation for ALTER UPDATE with `remote` table function
@zvonand zvonand mentioned this pull request Jan 15, 2026
Closed
25 tasks
zvonand pushed a commit to Altinity/ClickHouse that referenced this pull request Jan 15, 2026
@pufit @zvonand
Merge pull request ClickHouse#90761 from ClickHouse/pufit/fix-access-…
0cbda8d 
…alter-with-remote

Fix access validation for ALTER UPDATE with `remote` table function
zvonand pushed a commit to Altinity/ClickHouse that referenced this pull request Jan 27, 2026
@pufit @zvonand
Merge pull request ClickHouse#90761 from ClickHouse/pufit/fix-access-…
1832f50 
…alter-with-remote

Fix access validation for ALTER UPDATE with `remote` table function
pufit added a commit that referenced this pull request Feb 3, 2026
@pufit
Merge pull request #91754 from ClickHouse/backport/25.8/90761
a9ae4f7 
Backport #90761 to 25.8: Fix access validation for ALTER UPDATE with `remote` table function
pufit added a commit that referenced this pull request Feb 3, 2026
@pufit
Merge pull request #92343 from ClickHouse/backport/25.3/90761
265cdaf 
Backport #90761 to 25.3: Fix access validation for ALTER UPDATE with `remote` table function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SmitaRKulkarni SmitaRKulkarni SmitaRKulkarni approved these changes

Assignees

@SmitaRKulkarni SmitaRKulkarni

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-critical-bugfix pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pufit @SmitaRKulkarni @robot-ch-test-poll @robot-ch-test-poll1 @robot-ch-test-poll3