Skip to content

Fix SYSTEM DROP FILESYSTEM CACHE ON CLUSTER#91304

Merged
kssenii merged 1 commit intoClickHouse:masterfrom
ianton-ru:system_drop_filesystem_cache_on_cluster
Dec 2, 2025
Merged

Fix SYSTEM DROP FILESYSTEM CACHE ON CLUSTER#91304
kssenii merged 1 commit intoClickHouse:masterfrom
ianton-ru:system_drop_filesystem_cache_on_cluster

Conversation

@ianton-ru
Copy link
Contributor

@ianton-ru ianton-ru commented Dec 2, 2025

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix SYSTEM DROP FILESYSTEM CACHE ON CLUSTER

Documentation entry for user-facing changes

Parser expects query

SYSTEM DROP FILESYSTEM CACHE 'cache_name' ON CLUSTER `cluster_name`

but in DDL cluster name is at end:

SYSTEM DROP FILESYSTEM CACHE ON CLUSTER `cluster_name` 'cache_name'

and query failed with error

clickhouse1 :) SYSTEM DROP FILESYSTEM CACHE 'cache' ON CLUSTER `clickhouse-cluster`

SYSTEM DROP FILESYSTEM CACHE ON CLUSTER `clickhouse-cluster` 'cache'

Query id: 48c41c7b-bb81-4b9e-a49a-fcd8b5a537cb

Row 1:
──────
host:                clickhouse2
port:                9000
status:              62
error:               Code: 62. DB::Exception: Syntax error: failed at position 62 ('cache'): 'cache'. Expected one of: ParallelWithClause, PARALLEL WITH, end of query. (SYNTAX_ERROR) (version 25.8.10.7 (official build))
num_hosts_remaining: 2
num_hosts_active:    0

Row 2:
──────
host:                clickhouse1
port:                9000
status:              62
error:               Code: 62. DB::Exception: Syntax error: failed at position 62 ('cache'): 'cache'. Expected one of: ParallelWithClause, PARALLEL WITH, end of query. (SYNTAX_ERROR) (version 25.8.10.7 (official build))
num_hosts_remaining: 1
num_hosts_active:    0

Row 3:
──────
host:                clickhouse3
port:                9000
status:              62
error:               Code: 62. DB::Exception: Syntax error: failed at position 62 ('cache'): 'cache'. Expected one of: ParallelWithClause, PARALLEL WITH, end of query. (SYNTAX_ERROR) (version 25.8.10.7 (official build))
num_hosts_remaining: 0
num_hosts_active:    0

3 rows in set. Elapsed: 0.099 sec.

Received exception from server (version 25.8.10):
Code: 62. DB::Exception: Received from localhost:9000. DB::Exception: There was an error on [clickhouse2:9000]: Code: 62. DB::Exception: Syntax error: failed at position 62 ('cache'): 'cache'. Expected one of: ParallelWithClause, PARALLEL WITH, end of query. (SYNTAX_ERROR) (version 25.8.10.7 (official build)). (SYNTAX_ERROR)
  • Documentation is written (mandatory for new features)

@kssenii kssenii self-assigned this Dec 2, 2025
@kssenii kssenii added the can be tested Allows running workflows for external contributors label Dec 2, 2025
@clickhouse-gh
Copy link
Contributor

clickhouse-gh bot commented Dec 2, 2025 •
edited
Loading

Workflow [PR], commit [a79097e]

Summary: ❌

job_name test_name status info comment
Stateless tests (arm_asan, targeted) failure
02015_async_inserts_4 FAIL cidb
02015_async_inserts_4 FAIL cidb
02015_async_inserts_4 FAIL cidb
02015_async_inserts_4 FAIL cidb
02015_async_inserts_4 FAIL cidb
Stateless tests (amd_msan, parallel) failure
00906_low_cardinality_cache FAIL cidb, issue
Stateless tests (amd_debug, distributed plan, s3 storage, sequential) failure
01459_manual_write_to_replicas_quorum_detach_attach FAIL cidb, issue
BuzzHouse (amd_debug) failure
Logical error: 'Inconsistent AST formatting: the query: FAIL cidb, issue

@clickhouse-gh clickhouse-gh bot added the pr-bugfix Pull request with bugfix, not backported by default label Dec 2, 2025
@kssenii kssenii added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Dec 2, 2025
@ianton-ru
Copy link
Contributor Author

ianton-ru commented Dec 2, 2025 •
edited
Loading

Failed tests:

  • BuzzHouse (amd_debug) - Logical error: 'Inconsistent AST formatting: the query,, NOT vs not, as I understand.
  • 01459_manual_write_to_replicas_quorum_detach_attach - DB::Exception: Table is in readonly mode (replica path: /clickhouse/tables/01459_manual_write_to_replicas_quorum_detach_attach_test_0kf796a8/r/replicas/r2).
  • 00906_low_cardinality_cache - timeout
  • 02015_async_inserts_4 - role role_02015: cannot insert because role role_02015already exists inlocal_directory.

Everything looks irrelevant.

@kssenii kssenii added this pull request to the merge queue Dec 2, 2025
Merged via the queue into ClickHouse:master with commit 6f1f13d Dec 2, 2025
125 of 130 checks passed
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Dec 2, 2025
@robot-ch-test-poll robot-ch-test-poll added the pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR label Dec 2, 2025
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 mentioned this pull request Dec 2, 2025
Merged
robot-clickhouse-ci-2 added a commit that referenced this pull request Dec 2, 2025
@robot-clickhouse-ci-2
Merge pull request #91333 from ClickHouse/cherrypick/25.3/91304
2cc6b63 
Cherry pick #91304 to 25.3: Fix SYSTEM DROP FILESYSTEM CACHE ON CLUSTER
robot-clickhouse added a commit that referenced this pull request Dec 2, 2025
@robot-clickhouse
Backport #91304 to 25.3: Fix SYSTEM DROP FILESYSTEM CACHE ON CLUSTER
1d9c74a
This was referenced Dec 2, 2025
Merged
Merged
robot-clickhouse-ci-2 added a commit that referenced this pull request Dec 2, 2025
@robot-clickhouse-ci-2
Merge pull request #91335 from ClickHouse/cherrypick/25.8/91304
2a1eb3e 
Cherry pick #91304 to 25.8: Fix SYSTEM DROP FILESYSTEM CACHE ON CLUSTER
robot-clickhouse added a commit that referenced this pull request Dec 2, 2025
@robot-clickhouse
Backport #91304 to 25.8: Fix SYSTEM DROP FILESYSTEM CACHE ON CLUSTER
3cf92fa
This was referenced Dec 2, 2025
Merged
Merged
robot-clickhouse-ci-2 added a commit that referenced this pull request Dec 2, 2025
@robot-clickhouse-ci-2
Merge pull request #91337 from ClickHouse/cherrypick/25.9/91304
01a7a59 
Cherry pick #91304 to 25.9: Fix SYSTEM DROP FILESYSTEM CACHE ON CLUSTER
robot-clickhouse added a commit that referenced this pull request Dec 2, 2025
@robot-clickhouse
Backport #91304 to 25.9: Fix SYSTEM DROP FILESYSTEM CACHE ON CLUSTER
6cc2c3b
This was referenced Dec 2, 2025
Merged
Merged
robot-clickhouse-ci-2 added a commit that referenced this pull request Dec 2, 2025
@robot-clickhouse-ci-2
Merge pull request #91339 from ClickHouse/cherrypick/25.10/91304
3dd68eb 
Cherry pick #91304 to 25.10: Fix SYSTEM DROP FILESYSTEM CACHE ON CLUSTER
robot-clickhouse added a commit that referenced this pull request Dec 2, 2025
@robot-clickhouse
Backport #91304 to 25.10: Fix SYSTEM DROP FILESYSTEM CACHE ON CLUSTER
03a5351
This was referenced Dec 2, 2025
Merged
Merged
robot-clickhouse-ci-2 added a commit that referenced this pull request Dec 2, 2025
@robot-clickhouse-ci-2
Merge pull request #91341 from ClickHouse/cherrypick/25.11/91304
d1c09ec 
Cherry pick #91304 to 25.11: Fix SYSTEM DROP FILESYSTEM CACHE ON CLUSTER
robot-clickhouse added a commit that referenced this pull request Dec 2, 2025
@robot-clickhouse
Backport #91304 to 25.11: Fix SYSTEM DROP FILESYSTEM CACHE ON CLUSTER
86ff256
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 mentioned this pull request Dec 2, 2025
Merged
@robot-ch-test-poll robot-ch-test-poll added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Dec 2, 2025
clickhouse-gh bot added a commit that referenced this pull request Dec 2, 2025
@clickhouse-gh
Merge pull request #91340 from ClickHouse/backport/25.10/91304
3a8534a 
Backport #91304 to 25.10: Fix SYSTEM DROP FILESYSTEM CACHE ON CLUSTER
clickhouse-gh bot added a commit that referenced this pull request Dec 2, 2025
@clickhouse-gh
Merge pull request #91342 from ClickHouse/backport/25.11/91304
7930df8 
Backport #91304 to 25.11: Fix SYSTEM DROP FILESYSTEM CACHE ON CLUSTER
clickhouse-gh bot added a commit that referenced this pull request Dec 2, 2025
@clickhouse-gh
Merge pull request #91338 from ClickHouse/backport/25.9/91304
9511d6b 
Backport #91304 to 25.9: Fix SYSTEM DROP FILESYSTEM CACHE ON CLUSTER
kssenii added a commit that referenced this pull request Dec 4, 2025
@kssenii
Merge pull request #91334 from ClickHouse/backport/25.3/91304
a88d228 
Backport #91304 to 25.3: Fix SYSTEM DROP FILESYSTEM CACHE ON CLUSTER
kssenii added a commit that referenced this pull request Dec 4, 2025
@kssenii
Merge pull request #91336 from ClickHouse/backport/25.8/91304
ffa905e 
Backport #91304 to 25.8: Fix SYSTEM DROP FILESYSTEM CACHE ON CLUSTER
@ianton-ru ianton-ru mentioned this pull request Jan 12, 2026
Merged
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kssenii kssenii kssenii approved these changes

Assignees

@kssenii kssenii

Labels

can be tested Allows running workflows for external contributors pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ianton-ru @kssenii @robot-ch-test-poll @robot-ch-test-poll2