Skip to content

Proper handle sparse nullable columns in inner/left joins#93038

Merged
Avogar merged 1 commit intoClickHouse:masterfrom
amosbird:fix-92920
Dec 29, 2025
Merged

Proper handle sparse nullable columns in inner/left joins#93038
Avogar merged 1 commit intoClickHouse:masterfrom
amosbird:fix-92920

Conversation

@amosbird
Copy link
Collaborator

@amosbird amosbird commented Dec 25, 2025

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Fix join results when the right-side join key is a sparse column. This closes #92920. I can only reproduce the bug with set compatibility='23.3'. Not sure if it should be backported.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link
Contributor

clickhouse-gh bot commented Dec 25, 2025 •
edited by Avogar
Loading

Workflow [PR], commit [1ef1fa5]

Summary: ❌

job_name test_name status info comment
Integration tests (amd_asan, db disk, old analyzer, 2/6) failure
test_storage_s3_queue/test_5.py::test_shutdown_order FAIL IGNORED
test_storage_s3_queue/test_5.py::test_mv_settings[1-unordered] FAIL IGNORED
test_storage_s3_queue/test_5.py::test_mv_settings[1-ordered] FAIL IGNORED
test_storage_s3_queue/test_5.py::test_mv_settings[9999999999-unordered] FAIL IGNORED
test_storage_s3_queue/test_5.py::test_mv_settings[9999999999-ordered] FAIL IGNORED
test_storage_s3_queue/test_5.py::test_detach_attach_table FAIL IGNORED
test_storage_s3_queue/test_5.py::test_failed_startup FAIL IGNORED
test_storage_s3_queue/test_5.py::test_create_or_replace_table FAIL IGNORED
test_storage_s3_queue/test_5.py::test_persistent_processing_nodes_cleanup FAIL IGNORED
test_storage_s3_queue/test_5.py::test_persistent_processing FAIL IGNORED
2 more test cases not shown
Integration tests (arm_binary, distributed plan, 4/4) failure
test_userspace_page_cache/test.py::test_size_adjustment FAIL issue ISSUE EXISTS
Integration tests (amd_tsan, 2/6) failure
test_backup_restore_on_cluster/test_disallow_concurrency.py::test_concurrent_backups_on_same_node FAIL IGNORED
test_backup_restore_on_cluster/test_disallow_concurrency.py::test_concurrent_backups_on_different_nodes FAIL IGNORED
test_backup_restore_on_cluster/test_disallow_concurrency.py::test_concurrent_restores_on_same_node FAIL issue ISSUE EXISTS
test_backup_restore_on_cluster/test_disallow_concurrency.py::test_concurrent_restores_on_different_node FAIL IGNORED
test_storage_s3_queue/test_5.py::test_shutdown_order FAIL IGNORED
BuzzHouse (amd_debug) failure
Logical error: 'Inconsistent AST formatting: the query: (STID: 1941-1bfa) FAIL issue ISSUE EXISTS

@clickhouse-gh clickhouse-gh bot added the pr-bugfix Pull request with bugfix, not backported by default label Dec 25, 2025
@Avogar Avogar self-assigned this Dec 29, 2025
@Avogar Avogar added this pull request to the merge queue Dec 29, 2025
Merged via the queue into ClickHouse:master with commit 39e022d Dec 29, 2025
126 of 131 checks passed
@robot-clickhouse robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label Dec 29, 2025
@fm4v fm4v added pr-must-backport Pull request should be backported intentionally. Use this label with great care! v25.12-must-backport labels Jan 21, 2026
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR label Jan 21, 2026
@robot-clickhouse robot-clickhouse mentioned this pull request Jan 21, 2026
Merged
robot-clickhouse added a commit that referenced this pull request Jan 21, 2026
@robot-clickhouse
Merge pull request #94758 from ClickHouse/cherrypick/25.3/93038
4974791 
Cherry pick #93038 to 25.3: Proper handle sparse nullable columns in inner/left joins
robot-clickhouse added a commit that referenced this pull request Jan 21, 2026
@robot-clickhouse
Backport #93038 to 25.3: Proper handle sparse nullable columns in inn…
4e14635 
…er/left joins
This was referenced Jan 21, 2026
Closed
Merged
robot-clickhouse added a commit that referenced this pull request Jan 21, 2026
@robot-clickhouse
Merge pull request #94760 from ClickHouse/cherrypick/25.8/93038
0a398d2 
Cherry pick #93038 to 25.8: Proper handle sparse nullable columns in inner/left joins
robot-clickhouse added a commit that referenced this pull request Jan 21, 2026
@robot-clickhouse
Backport #93038 to 25.8: Proper handle sparse nullable columns in inn…
c3a5247 
…er/left joins
This was referenced Jan 21, 2026
Merged
Merged
robot-clickhouse added a commit that referenced this pull request Jan 21, 2026
@robot-clickhouse
Merge pull request #94762 from ClickHouse/cherrypick/25.10/93038
f141a10 
Cherry pick #93038 to 25.10: Proper handle sparse nullable columns in inner/left joins
robot-clickhouse added a commit that referenced this pull request Jan 21, 2026
@robot-clickhouse
Backport #93038 to 25.10: Proper handle sparse nullable columns in in…
5967a8d 
…ner/left joins
This was referenced Jan 21, 2026
Merged
Merged
robot-clickhouse added a commit that referenced this pull request Jan 21, 2026
@robot-clickhouse
Merge pull request #94764 from ClickHouse/cherrypick/25.11/93038
37f87d5 
Cherry pick #93038 to 25.11: Proper handle sparse nullable columns in inner/left joins
robot-clickhouse added a commit that referenced this pull request Jan 21, 2026
@robot-clickhouse
Backport #93038 to 25.11: Proper handle sparse nullable columns in in…
f77a952 
…ner/left joins
This was referenced Jan 21, 2026
Merged
Merged
robot-clickhouse added a commit that referenced this pull request Jan 21, 2026
@robot-clickhouse
Merge pull request #94766 from ClickHouse/cherrypick/25.12/93038
3b4659a 
Cherry pick #93038 to 25.12: Proper handle sparse nullable columns in inner/left joins
robot-clickhouse added a commit that referenced this pull request Jan 21, 2026
@robot-clickhouse
Backport #93038 to 25.12: Proper handle sparse nullable columns in in…
a1525ab 
…ner/left joins
@robot-clickhouse robot-clickhouse mentioned this pull request Jan 21, 2026
Merged
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Jan 21, 2026
Avogar added a commit that referenced this pull request Jan 23, 2026
@Avogar
Merge pull request #94767 from ClickHouse/backport/25.12/93038
cdb7427 
Backport #93038 to 25.12: Proper handle sparse nullable columns in inner/left joins
Avogar added a commit that referenced this pull request Jan 23, 2026
@Avogar
Merge pull request #94765 from ClickHouse/backport/25.11/93038
9c1fb70 
Backport #93038 to 25.11: Proper handle sparse nullable columns in inner/left joins
Avogar added a commit that referenced this pull request Jan 23, 2026
@Avogar
Merge pull request #94763 from ClickHouse/backport/25.10/93038
40dfb41 
Backport #93038 to 25.10: Proper handle sparse nullable columns in inner/left joins
Avogar added a commit that referenced this pull request Jan 23, 2026
@Avogar
Merge pull request #94761 from ClickHouse/backport/25.8/93038
c5e7f1c 
Backport #93038 to 25.8: Proper handle sparse nullable columns in inner/left joins
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Avogar Avogar Avogar approved these changes

Assignees

@Avogar Avogar

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo v25.12-must-backport

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Logical error: Column 'col1 Int64 Sparse(size = 0, Nullable(size = 1, Int64(size = 1), UInt8(size = 1)), UInt64(size = 0))' is expected to be nullable

6 participants

@amosbird @Avogar @fm4v @robot-clickhouse @robot-ch-test-poll1 @robot-ch-test-poll3