Fix data race in DataPartStorageOnDiskBase::remove vs system.parts#94262
Merged
alexey-milovidov merged 3 commits intomasterfrom Jan 16, 2026
Merged
Fix data race in DataPartStorageOnDiskBase::remove vs system.parts#94262alexey-milovidov merged 3 commits intomasterfrom
DataPartStorageOnDiskBase::remove vs system.parts#94262alexey-milovidov merged 3 commits intomasterfrom
Conversation
The data race occurred between: - Thread modifying part_dir in remove() after renaming directory - Thread reading part_dir in getFullPath() from system.parts queries The assignment to part_dir is unnecessary because: - The 'to' variable is already computed and used for all subsequent operations - The part is being removed, so the path doesn't need to be updated Co-Authored-By: Claude Opus 4.5 <[email protected]>
This test aims to trigger a race condition between: - Reading system.parts table (calling getFullPath()) - Removing parts (calling remove() which modifies part_dir) The test creates a table with minimal part lifetime, then runs concurrent inserts, partition drops, and system.parts queries. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Contributor
|
Workflow [PR], commit [3958d25] Summary: ❌
|
clickhouse-gh
bot
added
pr-critical-bugfix
pr-must-backport
Member
Author
|
This is okay, because it fails only under TSan. |
Member
|
nikitamikhaylov
approved these changes
Jan 14, 2026
robot-ch-test-poll1
added
the
pr-synced-to-cloud
robot-ch-test-poll2
added
the
pr-must-backport-synced
robot-ch-test-poll4
added a commit
that referenced
this pull request
Jan 16, 2026
Cherry pick #94262 to 25.3: Fix data race in `DataPartStorageOnDiskBase::remove` vs `system.parts`
robot-clickhouse
added a commit
that referenced
this pull request
Jan 16, 2026
…:remove` vs `system.parts`
robot-ch-test-poll4
added a commit
that referenced
this pull request
Jan 16, 2026
Cherry pick #94262 to 25.8: Fix data race in `DataPartStorageOnDiskBase::remove` vs `system.parts`
robot-clickhouse
added a commit
that referenced
this pull request
Jan 16, 2026
…:remove` vs `system.parts`
robot-ch-test-poll4
added a commit
that referenced
this pull request
Jan 16, 2026
Cherry pick #94262 to 25.10: Fix data race in `DataPartStorageOnDiskBase::remove` vs `system.parts`
robot-clickhouse
added a commit
that referenced
this pull request
Jan 16, 2026
…::remove` vs `system.parts`
robot-ch-test-poll4
added a commit
that referenced
this pull request
Jan 16, 2026
Cherry pick #94262 to 25.11: Fix data race in `DataPartStorageOnDiskBase::remove` vs `system.parts`
robot-clickhouse
added a commit
that referenced
this pull request
Jan 16, 2026
…::remove` vs `system.parts`
robot-ch-test-poll4
added a commit
that referenced
this pull request
Jan 16, 2026
Cherry pick #94262 to 25.12: Fix data race in `DataPartStorageOnDiskBase::remove` vs `system.parts`
robot-clickhouse
added a commit
that referenced
this pull request
Jan 16, 2026
…::remove` vs `system.parts`
robot-ch-test-poll1
added
the
pr-backports-created
clickhouse-gh bot
added a commit
that referenced
this pull request
Jan 16, 2026
Backport #94262 to 25.12: Fix data race in `DataPartStorageOnDiskBase::remove` vs `system.parts`
clickhouse-gh bot
added a commit
that referenced
this pull request
Jan 16, 2026
Backport #94262 to 25.11: Fix data race in `DataPartStorageOnDiskBase::remove` vs `system.parts`
alexey-milovidov
added a commit
that referenced
this pull request
Jan 17, 2026
Backport #94262 to 25.8: Fix data race in `DataPartStorageOnDiskBase::remove` vs `system.parts`
alexey-milovidov
added a commit
that referenced
this pull request
Jan 17, 2026
Backport #94262 to 25.10: Fix data race in `DataPartStorageOnDiskBase::remove` vs `system.parts`
This was referenced Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Fix data race in
DataPartStorageOnDiskBase::removevssystem.parts. Closes #49076.The test reproduces the problem successfully. Prompts: https://pastila.nl/?0009496a/7630a430e8273325d3acd6bfc71045d3#Iv1vnXsu1NFcfdLKPyJkFw==GCM