Skip to content

Fix reading columns with dot-separated names from Iceberg#94335

Merged
Avogar merged 5 commits intoClickHouse:masterfrom
mkmkme:dot-issue
Jan 29, 2026
Merged

Fix reading columns with dot-separated names from Iceberg#94335
Avogar merged 5 commits intoClickHouse:masterfrom
mkmkme:dot-issue

Conversation

@mkmkme
Copy link
Contributor

@mkmkme mkmkme commented Jan 15, 2026

Fixes #94196

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Fixes an issue when Iceberg columns with dot in names returned NULL as values

@mkmkme
Copy link
Contributor Author

mkmkme commented Jan 16, 2026

This fix does not take into account the case when the column with a dot is inside the struct. I can fix that. But I would like some feedback for that first :)

EDIT: this has been fixed now

@yariks5s yariks5s added the can be tested Allows running workflows for external contributors label Jan 20, 2026
@clickhouse-gh
Copy link
Contributor

clickhouse-gh bot commented Jan 20, 2026

Workflow [PR], commit [fbbec70]

Summary:

@clickhouse-gh clickhouse-gh bot added the pr-bugfix Pull request with bugfix, not backported by default label Jan 20, 2026
@mkmkme
Copy link
Contributor Author

mkmkme commented Jan 21, 2026

The failed tests are unrelated to the changes

@Avogar Avogar self-assigned this Jan 21, 2026
@mkmkme
Copy link
Contributor Author

mkmkme commented Jan 29, 2026

Hey @Avogar, did you get any chance to have a look at this?

Copy link
Member

@Avogar Avogar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for waiting, was busy last week. Looks good, let's merge

@Avogar Avogar added this pull request to the merge queue Jan 29, 2026
Merged via the queue into ClickHouse:master with commit ff54fe7 Jan 29, 2026
132 checks passed
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jan 29, 2026
@mkmkme mkmkme deleted the dot-issue branch February 3, 2026 10:44
mkmkme pushed a commit to Altinity/ClickHouse that referenced this pull request Feb 25, 2026
Fix reading columns with dot-separated names from Iceberg
zvonand added a commit to Altinity/ClickHouse that referenced this pull request Mar 2, 2026
Antalya 26.1 Backport of ClickHouse#94335 - Fix reading columns with dot-separated names from Iceberg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

can be tested Allows running workflows for external contributors pr-bugfix Pull request with bugfix, not backported by default pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can not read dot-separated column values in Iceberg tables starting from 25.11

4 participants