Cherry pick #94262 to 25.3: Fix data race in DataPartStorageOnDiskBase::remove vs system.parts#94437
Merged
robot-ch-test-poll4 merged 4 commits intobackport/25.3/94262from Jan 16, 2026
Merged
Conversation
The data race occurred between: - Thread modifying part_dir in remove() after renaming directory - Thread reading part_dir in getFullPath() from system.parts queries The assignment to part_dir is unnecessary because: - The 'to' variable is already computed and used for all subsequent operations - The part is being removed, so the path doesn't need to be updated Co-Authored-By: Claude Opus 4.5 <[email protected]>
This test aims to trigger a race condition between: - Reading system.parts table (calling getFullPath()) - Removing parts (calling remove() which modifies part_dir) The test creates a table with minimal part lifetime, then runs concurrent inserts, partition drops, and system.parts queries. Co-Authored-By: Claude Opus 4.5 <[email protected]>
…remove Fix data race in `DataPartStorageOnDiskBase::remove` vs `system.parts`
robot-ch-test-poll4
added
pr-cherrypick
robot-ch-test-poll4
merged commit 1dd9d2c
into
backport/25.3/94262
124 of 126 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original pull-request #94262
Do not merge this PR manually
This pull-request is a first step of an automated backporting.
It contains changes similar to calling
git cherry-picklocally.If you intend to continue backporting the changes, then resolve all conflicts if any.
Otherwise, if you do not want to backport them, then just close this pull-request.
The check results does not matter at this step - you can safely ignore them.
Troubleshooting
If the conflicts were resolved in a wrong way
If this cherry-pick PR is completely screwed by a wrong conflicts resolution, and you want to recreate it:
pr-cherrypicklabel from the PRYou also need to check the Original pull-request for
pr-backports-createdlabel, and delete if it's presented thereThe PR source
The PR is created in the CI job