Mask password in logs and system tables for the redis table function#95325
Merged
antaljanosbenjamin merged 1 commit intomasterfrom Jan 28, 2026
Merged
Mask password in logs and system tables for the redis table function#95325antaljanosbenjamin merged 1 commit intomasterfrom
redis table function#95325antaljanosbenjamin merged 1 commit intomasterfrom
Conversation
Contributor
|
Workflow [PR], commit [002ef60] Summary: ❌
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements password hiding for the redis table function in logs and system tables, addressing a security concern where sensitive credentials were previously exposed.
Changes:
- Added password masking logic for the
redistable function by implementingfindRedisFunctionSecretArguments()method - Renamed existing
findRedisSecretArguments()tofindRedisTableEngineSecretArguments()for clarity between table engine and table function handling - Added comprehensive test coverage for both
redistable function andRedistable engine password masking
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Parsers/FunctionSecretArgumentsFinder.h | Implements password masking for redis table function and renames existing method for table engine |
| tests/integration/test_mask_sensitive_info/test.py | Adds test cases verifying password masking works for both Redis table engine and redis table function |
clickhouse-gh
bot
added
pr-critical-bugfix
pr-must-backport
5 tasks
Contributor
|
@antaljanosbenjamin I've opened a new pull request, #95327, to work on those changes. Once the pull request is ready, I'll request review from you. |
antaljanosbenjamin
changed the title
redis table functionredis table function
antaljanosbenjamin
changed the title
redis table functionredis table function
kssenii
approved these changes
Jan 27, 2026
antaljanosbenjamin
changed the title
redis table functionredis table function
robot-ch-test-poll1
added
the
pr-must-backport-synced
This was referenced Jan 28, 2026
robot-clickhouse
added a commit
that referenced
this pull request
Jan 28, 2026
Cherry pick #95325 to 26.1: Mask password in logs and system tables for the `redis` table function
robot-clickhouse
added a commit
that referenced
this pull request
Jan 28, 2026
…the `redis` table function
clickhouse-gh bot
added a commit
that referenced
this pull request
Jan 28, 2026
Backport #95325 to 26.1: Mask password in logs and system tables for the `redis` table function
robot-ch-test-poll
added a commit
that referenced
this pull request
Jan 29, 2026
Cherry pick #95325 to 25.3: Mask password in logs and system tables for the `redis` table function
robot-clickhouse
added a commit
that referenced
this pull request
Jan 29, 2026
…the `redis` table function
robot-ch-test-poll
added a commit
that referenced
this pull request
Jan 29, 2026
Cherry pick #95325 to 25.8: Mask password in logs and system tables for the `redis` table function
robot-clickhouse
added a commit
that referenced
this pull request
Jan 29, 2026
…the `redis` table function
robot-ch-test-poll
added a commit
that referenced
this pull request
Jan 29, 2026
Cherry pick #95325 to 25.10: Mask password in logs and system tables for the `redis` table function
robot-clickhouse
added a commit
that referenced
this pull request
Jan 29, 2026
… the `redis` table function
robot-ch-test-poll
added a commit
that referenced
this pull request
Jan 29, 2026
Cherry pick #95325 to 25.11: Mask password in logs and system tables for the `redis` table function
robot-clickhouse
added a commit
that referenced
this pull request
Jan 29, 2026
… the `redis` table function
robot-clickhouse
added a commit
that referenced
this pull request
Jan 29, 2026
Cherry pick #95325 to 25.12: Mask password in logs and system tables for the `redis` table function
robot-clickhouse
added a commit
that referenced
this pull request
Jan 29, 2026
… the `redis` table function
robot-ch-test-poll
added
the
pr-backports-created
clickhouse-gh bot
added a commit
that referenced
this pull request
Jan 29, 2026
Backport #95325 to 25.11: Mask password in logs and system tables for the `redis` table function
antaljanosbenjamin
added a commit
that referenced
this pull request
Jan 30, 2026
Backport #95325 to 25.12: Mask password in logs and system tables for the `redis` table function
antaljanosbenjamin
added a commit
that referenced
this pull request
Jan 30, 2026
Backport #95325 to 25.8: Mask password in logs and system tables for the `redis` table function
antaljanosbenjamin
added a commit
that referenced
this pull request
Jan 30, 2026
Backport #95325 to 25.10: Mask password in logs and system tables for the `redis` table function
antaljanosbenjamin
added a commit
that referenced
this pull request
Jan 30, 2026
Backport #95325 to 25.3: Mask password in logs and system tables for the `redis` table function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
The password argument of the
redistable function now will be masked in the logs and system tables (e.g.:query_log).Documentation entry for user-facing changes