Skip to content

Fix storage lifetime with distributed plan#95356

Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
azat:dist-plan-hold-resources
Jan 29, 2026
Merged

Fix storage lifetime with distributed plan#95356
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
azat:dist-plan-hold-resources

Conversation

@azat
Copy link
Member

@azat azat commented Jan 28, 2026

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Fix storage lifetime with distributed plan

Fixes: #94661
Refs: #95074
Refs: #95123
Refs: #95129
Refs: https://pastila.nl/?00041955/59342d49e7432d7ccef84c97a048be06#i+KR1vVYkacqtXXJkBlpdw==GCM

@azat azat requested a review from KochetovNicolai January 28, 2026 09:49
@clickhouse-gh
Copy link
Contributor

clickhouse-gh bot commented Jan 28, 2026

Workflow [PR], commit [91ff5ec]

Summary:

job_name test_name status info comment
Finish Workflow failure
python3 ./ci/jobs/scripts/workflow_hooks/new_tests_check.py failure

@clickhouse-gh clickhouse-gh bot added the pr-bugfix Pull request with bugfix, not backported by default label Jan 28, 2026
@azat azat force-pushed the dist-plan-hold-resources branch from e2ffbb8 to 91ff5ec Compare January 28, 2026 10:10
@alexey-milovidov alexey-milovidov added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Jan 29, 2026
@alexey-milovidov alexey-milovidov self-assigned this Jan 29, 2026
@alexey-milovidov alexey-milovidov merged commit fdc5204 into ClickHouse:master Jan 29, 2026
131 of 134 checks passed
@robot-ch-test-poll robot-ch-test-poll added the pr-synced-to-cloud The PR is synced to the cloud repo label Jan 29, 2026
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR label Jan 29, 2026
robot-ch-test-poll3 added a commit that referenced this pull request Jan 29, 2026
Cherry pick #95356 to 25.8: Fix storage lifetime with distributed plan
robot-ch-test-poll3 added a commit that referenced this pull request Jan 29, 2026
Cherry pick #95356 to 25.10: Fix storage lifetime with distributed plan
robot-ch-test-poll3 added a commit that referenced this pull request Jan 29, 2026
Cherry pick #95356 to 25.11: Fix storage lifetime with distributed plan
robot-ch-test-poll3 added a commit that referenced this pull request Jan 29, 2026
Cherry pick #95356 to 25.12: Fix storage lifetime with distributed plan
robot-ch-test-poll3 added a commit that referenced this pull request Jan 29, 2026
Cherry pick #95356 to 26.1: Fix storage lifetime with distributed plan
@azat
Copy link
Member Author

azat commented Jan 29, 2026

@alexey-milovidov do we really need to backport this? Distributed plan is an experimental feature

clickhouse-gh bot added a commit that referenced this pull request Jan 29, 2026
Backport #95356 to 26.1: Fix storage lifetime with distributed plan
clickhouse-gh bot added a commit that referenced this pull request Jan 29, 2026
Backport #95356 to 25.8: Fix storage lifetime with distributed plan
azat added a commit that referenced this pull request Jan 29, 2026
Backport #95356 to 25.12: Fix storage lifetime with distributed plan
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Jan 29, 2026
@alexey-milovidov
Copy link
Member

@azat, not sure, but I was judging from the fact that it led to memory-safety issues.

@KochetovNicolai KochetovNicolai added the post-approved Approved, but after the PR is merged. label Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

post-approved Approved, but after the PR is merged. pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI crash] Incorrect destruction of MergeTreeDataPartCompact caches

6 participants