PromQL: Implement converting PromQLTree to string#97063
Merged
nikitamikhaylov merged 3 commits intoClickHouse:masterfrom Feb 20, 2026
Merged
PromQL: Implement converting PromQLTree to string#97063nikitamikhaylov merged 3 commits intoClickHouse:masterfrom
nikitamikhaylov merged 3 commits intoClickHouse:masterfrom
Conversation
vitlibar
added
the
comp-promql
Contributor
clickhouse-gh
bot
added
pr-not-for-changelog
vitlibar
changed the title
vitlibar
force-pushed
the
implement-converting-promql-tree-to-string
branch
from
8c46a88 to
4b2bf76
Compare
vitlibar
force-pushed
the
implement-converting-promql-tree-to-string
branch
from
4b2bf76 to
437f28b
Compare
vitlibar
commented
Feb 16, 2026
| StringLiteral() { node_type = NodeType::StringLiteral; result_type = ResultType::STRING; } | ||
| Node * clone(std::vector<std::unique_ptr<Node>> & node_list_) const override; | ||
| String dumpNode(const PrometheusQueryTree & tree, size_t indent) const override; | ||
| String toString(const PrometheusQueryTree & tree) const override; |
Member
Author
There was a problem hiding this comment.
This PR adds function toString() which outputs a PrometheusQueryTree to string in the format which can be parsed back.
Member
Author
|
Ready for review |
… Remote Read protocol.
vitlibar
force-pushed
the
implement-converting-promql-tree-to-string
branch
from
437f28b to
6e1c9ef
Compare
nikitamikhaylov
approved these changes
Feb 20, 2026
robot-ch-test-poll2
added
the
pr-synced-to-cloud
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Implement converting PromQLTree to string and use this conversion to simplify function
timeSeriesSelector().