Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for serializing Boolean values by incorporating Bool type handling into the binary reader and updating the associated test and schema creation files.
- Added a new Boolean field with its getter/setter in SimplePOJO.
- Updated SQL queries and table creation SQL to include and utilize the new Bool type.
- Extended the binaryReaderMethodForType logic in SerializerUtils to support Bool serialization.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| client-v2/src/test/java/com/clickhouse/client/query/SimplePOJO.java | Added a Boolean field "bool" with corresponding getter and setter methods, and updated toString() to include it. |
| client-v2/src/test/java/com/clickhouse/client/query/QueryTests.java | Modified the test query to select a Boolean constant and assert its value. |
| client-v2/src/test/java/com/clickhouse/client/query/QuerySamplePOJO.java | Updated the table creation SQL to use the Bool type instead of UInt8 for "bool" column. |
| client-v2/src/test/java/com/clickhouse/client/api/data_formats/internal/SerializerUtils.java | Added a new switch case to handle Bool type serialization by mapping it to readByte. |
Comments suppressed due to low confidence (1)
client-v2/src/test/java/com/clickhouse/client/api/data_formats/internal/SerializerUtils.java:960
- [nitpick] The new Bool case in binaryReaderMethodForType maps Bool to readByte and returns a byte descriptor, which may require implicit conversion to a Boolean. Consider using a dedicated boolean reader method if available or adding explicit conversion logic to improve clarity.
case Bool:
chernser
approved these changes
May 16, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
binaryReaderMethodForTypeCloses #2248
Checklist
Delete items not relevant to your PR: