Conversation
![windsurf-bot[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/1066231?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Other comments (1)
- jdbc-v2/src/test/java/com/clickhouse/jdbc/PreparedStatementTest.java (1061-1063) Parameter index 1 is set twice before execution. The first call to stmt.setString(1, "1000") is redundant and can be removed.
💡 To request another review, post a new comment with "/windsurf-review".
| DECIMAL_LITERAL : DEC_DIGIT+; | ||
| HEXADECIMAL_LITERAL : '0' X HEX_DIGIT+; | ||
|
|
||
| CAST_OP : '::'; |
Contributor
There was a problem hiding this comment.
Please add unit or integration tests to verify the correct handling of the new CAST_OP token and cast grammar (e.g., ?::integer, ?::UUID). This ensures the lexer and parser changes are covered and prevents regressions.
| | LBRACKET columnExprList? RBRACKET # ColumnExprArray | ||
| | columnIdentifier # ColumnExprIdentifier | ||
| | QUERY # ColumnExprParam | ||
| | QUERY CAST_OP identifier # ColumnExprParamWithCast |
Contributor
There was a problem hiding this comment.
Tests are required for the new cast operation grammar (e.g., ?::integer). Please add or update unit/integration tests to ensure this functionality is covered.
jdbc-v2/src/main/java/com/clickhouse/jdbc/internal/ParsedPreparedStatement.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds grammar for cast operation:
?:: integeror?::UUIDCloses #2422
Checklist
Delete items not relevant to your PR: