Improve string column dict encoding performance#15
Closed
taiyang-li wants to merge 2 commits intoClickHouse:mainfrom
Closed
Improve string column dict encoding performance#15taiyang-li wants to merge 2 commits intoClickHouse:mainfrom
taiyang-li wants to merge 2 commits intoClickHouse:mainfrom
Conversation
…dd/StringColumnWriter::add/CharColumnWriter::add
Author
|
I have created a pr with current changes to upstream: apache#2010 |
Author
|
It is probably that another PR contributed to upsteam will be merged in a few days. Let's turn this PR into draft status. |
ffacs
pushed a commit
to apache/orc
that referenced
this pull request
Sep 3, 2024
…and support EncodedStringVectorBatch for StringColumnWriter ### What changes were proposed in this pull request? Improve writing performance of encoded string column and support EncodedStringVectorBatch for StringColumnWriter. Performance was measured in ClickHouse#15 ### Why are the changes needed? ### How was this patch tested? original tests. ### Was this patch authored or co-authored using generative AI tooling? Closes #2010 from taiyang-li/apache_improve_dict_write. Lead-authored-by: taiyang-li <[email protected]> Co-authored-by: 李扬 <[email protected]> Signed-off-by: ffacs <[email protected]>
taiyang-li
added a commit
to taiyang-li/orc
that referenced
this pull request
Sep 4, 2024
…and support EncodedStringVectorBatch for StringColumnWriter Improve writing performance of encoded string column and support EncodedStringVectorBatch for StringColumnWriter. Performance was measured in ClickHouse#15 original tests. Closes apache#2010 from taiyang-li/apache_improve_dict_write. Lead-authored-by: taiyang-li <[email protected]> Co-authored-by: 李扬 <[email protected]> Signed-off-by: ffacs <[email protected]>
taiyang-li
added a commit
to taiyang-li/orc
that referenced
this pull request
Sep 4, 2024
…and support EncodedStringVectorBatch for StringColumnWriter Improve writing performance of encoded string column and support EncodedStringVectorBatch for StringColumnWriter. Performance was measured in ClickHouse#15 original tests. Closes apache#2010 from taiyang-li/apache_improve_dict_write. Lead-authored-by: taiyang-li <[email protected]> Co-authored-by: 李扬 <[email protected]> Signed-off-by: ffacs <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Improve writing performance of encoded string column. Speed up by 2x
Why are the changes needed?
How was this patch tested?
I tested it with clickhouse branch: ClickHouse/ClickHouse#68591
Query:
Before current optimization:
After current optimization: