Merged
Conversation
azat
added a commit
to azat/ClickHouse
that referenced
this pull request
Oct 29, 2025
Not always github allows to fetch via upstream repo, sometimes it gives
"fatal: Fetched in submodule path 'contrib/zstd', but it did not contain
X." error [1].
fatal: transport 'file' not allowed
fatal: Fetched in submodule path 'contrib/zstd', but it did not contain 437081852c396eeb61edb7d47044d8cad911885e. Direct fetching of that commit failed.
Refs:
- ClickHouse/zstd#2
- ClickHouse/thrift#2
azat
added a commit
to azat/ClickHouse
that referenced
this pull request
Oct 29, 2025
Not always github allows to fetch via upstream repo, sometimes it gives
"fatal: Fetched in submodule path 'contrib/zstd', but it did not contain
X." error [1].
fatal: transport 'file' not allowed
fatal: Fetched in submodule path 'contrib/zstd', but it did not contain 437081852c396eeb61edb7d47044d8cad911885e. Direct fetching of that commit failed.
Refs:
- ClickHouse/zstd#2
- ClickHouse/thrift#2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std::locale("C")doesn't work in clickhouse because we disallowlocaleconvlibc function (inClickHouse/base/harmful/harmful.c). Thrift doesstd::ostream::imbue(std::locale("C"))when formatting thrift structs as string, presumably to make formatting of floats independent of environment. This PR just replacesstd::locale("C")withstd::locale::classic(), which should be equivalent according to documentation (Returns a reference to the "C" locale), but doesn't calllocaleconv.