Add no_cleanup_failed option for not cleaning up failed tests#30
Merged
Naktibalda merged 3 commits intoCodeception:masterfrom Mar 5, 2022
Merged
Add no_cleanup_failed option for not cleaning up failed tests#30Naktibalda merged 3 commits intoCodeception:masterfrom
Naktibalda merged 3 commits intoCodeception:masterfrom
Conversation
Contributor
Author
|
It will most likely need a cleanup once the debugging is done. 😄 |
Naktibalda
reviewed
Jan 6, 2022
src/Codeception/Module/Db.php
Outdated
| 'waitlock' => 0, | ||
| 'dump' => null, | ||
| 'populator' => null, | ||
| 'no_cleanup_failed' => false, |
Member
There was a problem hiding this comment.
I think that skip_cleanup_if_failed would be a better name for this setting.
TavoNiievez
reviewed
Jan 6, 2022
Member
TavoNiievez
left a comment
TavoNiievez
left a comment
There was a problem hiding this comment.
This new configuration option must be documented in more places than in the documentation for the haveInDatabase method, for example on line 48-65 of this file, and in some of the yml examples below.
TavoNiievez
approved these changes
Feb 25, 2022
Naktibalda
pushed a commit
that referenced
this pull request
Mar 5, 2022
* Add no_cleanup_failed option for not cleaning up failed tests * Update to handle all databases * Change name from 'no_cleanup_failed' to 'skip_cleanup_if_failed'
Naktibalda
pushed a commit
that referenced
this pull request
Mar 5, 2022
* Add no_cleanup_failed option for not cleaning up failed tests * Update to handle all databases * Change name from 'no_cleanup_failed' to 'skip_cleanup_if_failed'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I thought I'd add an option for not having it cleanup the database in case the test failed.