[bugfix] #49 Fix last insert id return type in case of FreeTDS (2.x)#50
[bugfix] #49 Fix last insert id return type in case of FreeTDS (2.x)#50szhajdu wants to merge 3 commits intoCodeception:2.xfrom szhajdu:fix-last-insert-id-return-type
Conversation
|
Thanks for the effort, now please merge the changes from 2.x branch and fix the tests. #48 added new binary field to users table, so you have to add it to mssql.sql. Also it seems that MSSQL driver can't handle binary parameters, can you fix that? https://github.com/Codeception/module-db/actions/runs/4454329549/jobs/7823434721
|
|
I have reviewed the issue and it appears that the solution may be more complex. For the sqlsrv driver, we will need to use Furthermore, I have discovered a bug related to dblib: php/php-src#10312. So related tests cannot be fixed until it is fixed in the driver itself. I would appreciate your input on how to proceed. Thank you. |
|
I think that overriding If tests can't be fixed, they can be skipped. Failing binary assertions must be moved to separate methods. |
The sqlsrv extension works fine, but in case of FreeTDS, lastInsertid returns with false when no auto increment on table.