Merged
Conversation
DerEchtePilz
requested changes
Jun 5, 2023
Member
DerEchtePilz
left a comment
DerEchtePilz
left a comment
There was a problem hiding this comment.
So, this were just points about the delimiter. To be able to submit another review (if necessary) I need to understand this first but that's on me :D
...-bukkit/commandapi-bukkit-core/src/main/java/dev/jorel/commandapi/arguments/MapArgument.java
Outdated
Show resolved
Hide resolved
.../commandapi-bukkit-core/src/main/java/dev/jorel/commandapi/arguments/MapArgumentBuilder.java
Outdated
Show resolved
Hide resolved
DerEchtePilz
approved these changes
Jun 6, 2023
DerEchtePilz
reviewed
Jun 6, 2023
JorelAli
requested changes
Jun 8, 2023
.../commandapi-bukkit-core/src/main/java/dev/jorel/commandapi/arguments/MapArgumentBuilder.java
Outdated
Show resolved
Hide resolved
.../commandapi-bukkit-core/src/main/java/dev/jorel/commandapi/arguments/MapArgumentBuilder.java
Outdated
Show resolved
Hide resolved
.../commandapi-bukkit-core/src/main/java/dev/jorel/commandapi/arguments/MapArgumentBuilder.java
Outdated
Show resolved
Hide resolved
...-bukkit/commandapi-bukkit-core/src/main/java/dev/jorel/commandapi/arguments/MapArgument.java
Outdated
Show resolved
Hide resolved
...-bukkit/commandapi-bukkit-core/src/main/java/dev/jorel/commandapi/arguments/MapArgument.java
Outdated
Show resolved
Hide resolved
...-bukkit/commandapi-bukkit-core/src/main/java/dev/jorel/commandapi/arguments/MapArgument.java
Outdated
Show resolved
Hide resolved
...-bukkit/commandapi-bukkit-core/src/main/java/dev/jorel/commandapi/arguments/MapArgument.java
Outdated
Show resolved
Hide resolved
willkroboth
force-pushed
the
dev/map-argument
branch
from
de51f03 to
8feac14
Compare
Reverse escape quotes at the start of unquoted strings
This case originally threw an unhelpful IndexOutOfBounds on MapArgument line 453
willkroboth
force-pushed
the
dev/map-argument
branch
from
8feac14 to
05002bf
Compare
JorelAli
approved these changes
Jun 8, 2023
willkroboth
force-pushed
the
dev/map-argument
branch
from
5402462 to
a511a96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The focus of this PR is to expand the features of the
MapArgument. These includeStringinstead ofchardelimiters (so long delimiters like->are possible)Stringseparators between key-value pairs (instead of just space)This also generally recodes the internals of the
MapArgumentto use Brigadier'sStringReaderand merge logic shared between key and value processing.ArgumentMapTestshad many (perhaps too many :P) tests added with the goal of 100% Jacoco coverage.