Fix reference count to decrease correctly when initialization fails#122
Merged
Fix reference count to decrease correctly when initialization fails#122
Conversation
There was a problem hiding this comment.
Pull Request Overview
The PR addresses an issue where the reference count is not decreased correctly when initialization fails. Key changes include:
- Adding a new test (InitializationFailure) to verify that the reference count returns to zero even when initialization fails.
- Refactoring the UDS test to employ using declarations for proper disposal.
- Wrapping the native handler initialization in a try/catch block to ensure the runtime is released on exception.
- A minor formatting update in NativeRuntime.cs.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/YetAnotherHttpHandler.Test/YetAnotherHttpHandlerTest.cs | Adds pre-condition checks and a new test to cover initialization failure scenarios |
| test/YetAnotherHttpHandler.Test/UdsTest.cs | Updates resource management using "using" statements to guarantee disposal |
| src/YetAnotherHttpHandler/NativeRuntime.cs | Minor formatting update |
| src/YetAnotherHttpHandler/NativeHttpHandlerCore.cs | Introduces a try/catch to release the runtime if initialization fails |
mayuki
force-pushed
the
feature/FixLeakedRefCountOnInitialization
branch
from
8eb0fb6 to
cd148d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.