Conversation
Mashintime
commented
Dec 8, 2024
- Added a 'small screen' layout button that may be more approriate for smaller screens
- Updated default layout
|
|
||
| <span class="me-4 text-white" style="writing-mode: vertical-rl; transform: rotate(180deg);"> | ||
| screen settings | ||
| grid edit |
There was a problem hiding this comment.
I'm thinking about making the button entirely black with white text. What do you think? Then we might have a better contrast, compared to the other GUI elements. Also "grid edit" fits better, thanks! Question: Is there a difference between "grid edit" and "edit grid" ? Or is is just cosmetics?
There was a problem hiding this comment.
I don't know, I think it's way too big now. Making it more noticeable (black/white) might be a distraction. Maybe a brief animation that makes it's flash it couple of times when starting up?
There was a problem hiding this comment.
I think either grid edit or edit grid are ok. Was just trying to make it a bit slimmer.
There was a problem hiding this comment.
It feels, there are two version of this button. Different in size.
On Safari macOS it is as small as the text while it is bigger on other browsers
There was a problem hiding this comment.
Ahh, might be a bootstrap issue?
There was a problem hiding this comment.
Regarding black/white I agree with you while the icon is too big. If it's small, then it's not that distracting in my opinion. But might be something we need to play with
There was a problem hiding this comment.
Ahh, might be a bootstrap issue?
yes seems so. A fix results into very hacky ways, so I think we should keep it as it is for now
|
Good idea, @Mashintime 👍 |
|
Thats Firefox vs Safari |
| @@ -449,7 +518,7 @@ onMounted(() => { | |||
| <!-- <i class="bi bi-grip-vertical h5"> </i>--> | |||
|
|
|||
| <span class="me-4 text-white" style="writing-mode: vertical-rl; transform: rotate(180deg);"> | |||
There was a problem hiding this comment.
the me-4 seems to be the key. If we remove it, we have a regular view on Firefox, but the text is hidden on Safari.
There was a problem hiding this comment.
I unfortuneatly don't have anything that'll run Safari to test further.
|
@Mashintime what do you think, should we merge? We can address the Button related problem later or separately |
|
Probably better to address the button seperately. |
|
Okay, then let's merge |