Skip to content

Avoid activation failures due to link file errors#1466

Merged
DanTup merged 1 commit intoDart-Code:devfrom
tsangint:patch-1
Feb 18, 2019
Merged

Avoid activation failures due to link file errors#1466
DanTup merged 1 commit intoDart-Code:devfrom
tsangint:patch-1

Conversation

@tsangint
Copy link
Contributor

@tsangint tsangint commented Feb 16, 2019 •
edited
Loading

test

Reproduce step:

// In the project folder's primary directory
touch ln_origin.txt 
ln -s ln_origin.txt ln_linked.txt
rm ln_origin.txt
// open VSCode and activate Dart-Code(Flutter plugin)

If there is a soft link file, but the original file is deleted, fs.statSyncwill throw an error and cause the activation to fail.

@DanTup DanTup changed the base branch from master to dev February 18, 2019 10:05
@DanTup DanTup added this to the v2.25.0 milestone Feb 18, 2019
@DanTup
Copy link
Member

DanTup commented Feb 18, 2019

Good spot! Thanks for the fix! 👍

@DanTup DanTup merged commit 10fb2aa into Dart-Code:dev Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

is bug fix

Projects

None yet

Milestone

v2.25.0

Development

Successfully merging this pull request may close these issues.

2 participants

@tsangint @DanTup