Filter completions for items that are already imported via another library#1789
Merged
Filter completions for items that are already imported via another library#1789
Conversation
DanTup
added
is enhancement
DanTup
force-pushed
the
filter-completions-for-imports
branch
from
55d6771 to
e08ee18
Compare
…equest This doesn't change anything today because the server sends the event right before every completion, however if it's optimised there, we'll get the benefit here. Fixes #1776.
DanTup
force-pushed
the
filter-completions-for-imports
branch
from
e08ee18 to
0c004f1
Compare
This was referenced Jun 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1776, though there are still some questions about the logic that need to be checked.