Extend analysis to to custom file extensions; folding for non-Dart files#2022
Extend analysis to to custom file extensions; folding for non-Dart files#2022DanTup merged 1 commit intoDart-Code:masterfrom simolus3:use-custom-file-endings
Conversation
|
Thanks! This doesn't seem to include any changes to |
|
Ugh, scratch that - it's already handled via Thanks, I'll merge this for the next release! |
DanTup
added
in editor
|
When making some changes, I noticed here we only add from If you can think of a reason why it was done that way and/or why this may be a bad idea, let me know! |
|
I think I was afraid to unconditionally enable them so that Either way, thanks for informing me! I'll update the docs of my analyzer plugin to reflect this. |
|
Yeah I was thinking of renaming it, but it'd break people - but also, the flag is enabled by default so the risk seems low now :-) |
2 participants
To better support analyzer plugins on custom file endings, I've made two changes:
MODE_HTML) for extensions declared inadditionalAnalyzerFileExtensionsif the option to use the Angular plugin is turned on.With a plugin I'm writing, I could verify that auto-complete, folding, outline, problems, fixes and navigation are all working with this setup.
Fixes #1981
Potential problems
In the linked issue, you asked whether the analysis server would send problematic responses when used with unsupported files. I played around with this as the plugin was turned off, and I didn't run into any problems.
Further, that shouldn't have any impact on the first change because it only effects users who explicitly added a file to
additionalAnalyzerFileExtensions, which only makes sense when an appropriate plugin is available.